Add assert for recycled views with parent (facebook#49937)

Summary:

Adding an assert for recycled views still attached to their parent, which would lead to an exception when the view would be added to a new parent.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D70922503

Author: Nick Lefever

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java

@@ -12,6 +12,7 @@
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 import com.facebook.common.logging.FLog;
+import com.facebook.infer.annotation.Assertions;
 import com.facebook.react.bridge.BaseJavaModule;
 import com.facebook.react.bridge.ReactApplicationContext;
 import com.facebook.react.bridge.ReactContext;
@@ -257,6 +258,16 @@ public void onDropViewInstance(@NonNull T view) {
     if (recyclableViews != null) {
       T recyclableView = prepareToRecycleView(themedReactContext, view);
       if (recyclableView != null) {
+        Assertions.assertCondition(
+            recyclableView.getParent() == null,
+            "Recycled view ["
+                + view.getId()
+                + "] should not be attached to a parent. View: "
+                + view
+                + " Parent: "
+                + recyclableView.getParent()
+                + " ThemedReactContext: "
+                + themedReactContext);
         recyclableViews.push(recyclableView);
       }
     }