Implement sampling profile serializer #49191
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
force-pushed
the
export-D68439735
branch
from
ae3b184 to
5bc9c94
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 15, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 15, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
force-pushed
the
export-D68439735
branch
from
5bc9c94 to
f8b3984
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 17, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 17, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
force-pushed
the
export-D68439735
branch
from
f8b3984 to
cb0e065
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 25, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
force-pushed
the
export-D68439735
branch
from
cb0e065 to
d5ad062
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 25, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
force-pushed
the
export-D68439735
branch
from
d5ad062 to
f1e371d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
Summary: Pull Request resolved: facebook#48836 # Changelog: [Internal] When `Tracing.start` CDP method is received, here is what happens next: - `TracingAgent`, which intercepts the event will propagate this status to `Instance` by calling `startTracing()` on `InstanceAgent`. - `InstanceAgent` will propagate it to `Runtime` entities. The only difference, there is no concept of tracing for Runtime, it will only have an API for starting sampling profiler. When `Tracing.end` CDP method is received, it is propagated in the same order. There is also `collect*()` methods for collecting profiles. This has multiple benefits: - We can control when `Runtime` or `Instance` are recreated and can ask them to start recording trace profiles right away. This may be required when we would add support for Reload and Profile from Performance panel. - We might leverage this setup in the future, once we add instrumentation for Network panel. `InstanceAgent` will get notified when tracing started and will correspondingly notify other part of the infrastructure that will be responsible for recording network calls. - We remain being fully agnostic to the actual `Runtime`, see corresponding `RuntimeTargetDelegate` for `V8`. We don't have the capacity for implementing and maintaining sampling profiler capabilities for it, but this approach unblocks it from technical perspective, if someone would want to invest into this. `InstanceProfile` is a superset of `RuntimeSamplingProfile`. In the future, `InstanceProfile` may also include things like `NetworkProfile`, or similar stuff. The definition for `RuntimeSamplingProfile` will be added in D68414421 and relies on the availability of new API for sampling profiler in Hermes. Differential Revision: D68327630 Reviewed By: huntie
Summary: # Changelog: [Internal] Adding a new method to `RuntimeTarget` that will register it for Tracing. In our case, it will schedule a callback on JS executor that will register JavaScript thread with `PerformanceTracer`. Differential Revision: D69530984
Summary: # Changelog: [Internal] We will record event loop ticks and register corresponding `"RunTask"` Trace Event with our Trace Event engine. Since this is hot path, I've added some gating under macros that are being used for Fusebox initialization. There are also plans to add a public method to `PerformanceTracer` to get tracing status, so we could avoid cost of serialization / saving timestamps if trace is not being recorded. I believe rubennorte had plans on this, we will add it on top of that. > Q: Why not add this to TraceSection? Long-term, we will have a solution that will be one layer above TraceSection and this `EventLoopTaskReporterRAII`, it is risky now to modify existing `TraceSection` and rely on event names and attempt to map them to Trace Events. Differential Revision: D69399955
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
Summary: Pull Request resolved: facebook#49084 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. Added public methods to `PerformanceTracer` instance for registering `Profile` and `ProfileChunk` Trace Events. Also created data structs in `TraceEvent.h` to simplify serialization process for objects like call frames / samples / etc. Differential Revision: D68558805 Reviewed By: huntie
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Reviewed By: huntie Differential Revision: D68439735
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49191 # Changelog: [Internal] In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with `PerformanceTracer`. It encapsulates the logic of transforming list of samples to `"Profile"` and `"ProfileChunk"` trace events, which will be parsed by Chrome DevTools later. Differential Revision: D68439735 Reviewed By: huntie
|
This pull request was exported from Phabricator. Differential Revision: D68439735 |
hoxyq
force-pushed
the
export-D68439735
branch
from
f1e371d to
d2f1d7d
Compare
|
This pull request has been merged in 87d4300. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
In this diff we are adding another serializer, that will receive local sampling profile (in tracing domain), and will record corresponding Trace Events with
PerformanceTracer.It encapsulates the logic of transforming list of samples to
"Profile"and"ProfileChunk"trace events, which will be parsed by Chrome DevTools later.Differential Revision: D68439735