Serialize Hermes Profile to Tracing Profile #49082
Closed
+799
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
force-pushed
the
export-D68414421
branch
from
5685d7c to
9bd8d6f
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 4, 2025
Summary: # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 4, 2025
Summary: # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 4, 2025
Summary: # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 4, 2025
Summary: # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 5, 2025
Summary: # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
force-pushed
the
export-D68414421
branch
from
9bd8d6f to
56a20c7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
force-pushed
the
export-D68414421
branch
from
56a20c7 to
fae92d4
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 14, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 15, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 15, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
force-pushed
the
export-D68414421
branch
from
fae92d4 to
256b00a
Compare
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 17, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 17, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
force-pushed
the
export-D68414421
branch
from
256b00a to
d7093d1
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 25, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 25, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 25, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
force-pushed
the
export-D68414421
branch
from
d7093d1 to
d99fd14
Compare
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
force-pushed
the
export-D68414421
branch
from
d99fd14 to
4021eec
Compare
Summary: Pull Request resolved: facebook#48836 # Changelog: [Internal] When `Tracing.start` CDP method is received, here is what happens next: - `TracingAgent`, which intercepts the event will propagate this status to `Instance` by calling `startTracing()` on `InstanceAgent`. - `InstanceAgent` will propagate it to `Runtime` entities. The only difference, there is no concept of tracing for Runtime, it will only have an API for starting sampling profiler. When `Tracing.end` CDP method is received, it is propagated in the same order. There is also `collect*()` methods for collecting profiles. This has multiple benefits: - We can control when `Runtime` or `Instance` are recreated and can ask them to start recording trace profiles right away. This may be required when we would add support for Reload and Profile from Performance panel. - We might leverage this setup in the future, once we add instrumentation for Network panel. `InstanceAgent` will get notified when tracing started and will correspondingly notify other part of the infrastructure that will be responsible for recording network calls. - We remain being fully agnostic to the actual `Runtime`, see corresponding `RuntimeTargetDelegate` for `V8`. We don't have the capacity for implementing and maintaining sampling profiler capabilities for it, but this approach unblocks it from technical perspective, if someone would want to invest into this. `InstanceProfile` is a superset of `RuntimeSamplingProfile`. In the future, `InstanceProfile` may also include things like `NetworkProfile`, or similar stuff. The definition for `RuntimeSamplingProfile` will be added in D68414421 and relies on the availability of new API for sampling profiler in Hermes. Differential Revision: D68327630 Reviewed By: huntie
Summary: # Changelog: [Internal] Adding a new method to `RuntimeTarget` that will register it for Tracing. In our case, it will schedule a callback on JS executor that will register JavaScript thread with `PerformanceTracer`. Differential Revision: D69530984
Summary: # Changelog: [Internal] We will record event loop ticks and register corresponding `"RunTask"` Trace Event with our Trace Event engine. Since this is hot path, I've added some gating under macros that are being used for Fusebox initialization. There are also plans to add a public method to `PerformanceTracer` to get tracing status, so we could avoid cost of serialization / saving timestamps if trace is not being recorded. I believe rubennorte had plans on this, we will add it on top of that. > Q: Why not add this to TraceSection? Long-term, we will have a solution that will be one layer above TraceSection and this `EventLoopTaskReporterRAII`, it is risky now to modify existing `TraceSection` and rely on event names and attempt to map them to Trace Events. Differential Revision: D69399955
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Reviewed By: bgirard Differential Revision: D68414421
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Feb 27, 2025
Summary: Pull Request resolved: facebook#49082 # Changelog: [Internal] > NOTE: Some CI jobs are expected to fail, because changes in Hermes D67353585 should be landed first, and then grafted to Static Hermes. In this diff we will: - Call newly added API in Hermes from `HermesRuntimeTargetDelegate.cpp` - Define format for local Sampling Profile that will be used in Tracing domain - Implement formatter for Hermes Profile -> Tracign Profile Differential Revision: D68414421 Reviewed By: bgirard
|
This pull request was exported from Phabricator. Differential Revision: D68414421 |
hoxyq
force-pushed
the
export-D68414421
branch
from
4021eec to
9053b6a
Compare
|
This pull request has been merged in 1aced32. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
In this diff we will:
HermesRuntimeTargetDelegate.cppDifferential Revision: D68414421