Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stable API - Make classes inside com.facebook.react.views.progressbar internal #47376

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stable API - Make classes inside com.facebook.react.views.progressbar internal #47376

wants to merge 2 commits into from
+41 −127

Commits on Nov 5, 2024

  1. [skip ci] Stable API - Make classes in `com.facebook.react.views.safe… 

    …areaview` internal (facebook#47375)

Summary:

This makes the following class internal:
- ReactSafeAreaView
- ReactSafeAreaViewManager

Those classes should have not been exposed in the first place. Marked as breaking but no
meaningful usages are available in OSS:
https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.views.safeareaview.ReactSafeAreaView

Changelog:
[Android] [Breaking] - Stable API - Make classes in `com.facebook.react.views.safeareaview` internal

Differential Revision: D65422197
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    3ab787a View commit details
    Browse the repository at this point in the history

  2. Stable API - Make classes inside `com.facebook.react.views.progressba… 

    …r` internal (facebook#47376)

Summary:

This makes several classes inside `com.facebook.react.views.progressbar` internal:
- ReactProgressBarViewManager
- ProgressBarShadowNode
- ProgressBarContainerView

Those classes should have not been exposed in the first place and users should not depend on them directly.
Marked as Breaking but verified that there are no meaningful usages in OSS.

Changelog:
[Android] [Breaking] - Stable API - Make classes inside `com.facebook.react.views.progressbar` internal

Differential Revision: D65423290
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    a7f47f9 View commit details
    Browse the repository at this point in the history