Stable API - Make classes inside com.facebook.react.views.progressbar internal
#47376
+41
−127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65423290 |
…areaview` internal (facebook#47375) Summary: This makes the following class internal: - ReactSafeAreaView - ReactSafeAreaViewManager Those classes should have not been exposed in the first place. Marked as breaking but no meaningful usages are available in OSS: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.views.safeareaview.ReactSafeAreaView Changelog: [Android] [Breaking] - Stable API - Make classes in `com.facebook.react.views.safeareaview` internal Differential Revision: D65422197
…r` internal (facebook#47376) Summary: This makes several classes inside `com.facebook.react.views.progressbar` internal: - ReactProgressBarViewManager - ProgressBarShadowNode - ProgressBarContainerView Those classes should have not been exposed in the first place and users should not depend on them directly. Marked as Breaking but verified that there are no meaningful usages in OSS. Changelog: [Android] [Breaking] - Stable API - Make classes inside `com.facebook.react.views.progressbar` internal Differential Revision: D65423290
cortinico
force-pushed
the
export-D65423290
branch
from
6545164
to
a7f47f9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65423290 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This makes several classes inside
com.facebook.react.views.progressbarinternal:Those classes should have not been exposed in the first place and users should not depend on them directly.
Marked as Breaking but verified that there are no meaningful usages in OSS.
Changelog:
[Android] [Breaking] - Stable API - Make classes inside
com.facebook.react.views.progressbarinternalDifferential Revision: D65423290