Require Flow types in all react-native source files #45786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 29, 2024
Summary: Pull Request resolved: facebook#45786 Following D60377082, `packages/react-native/Libraries/` is now 100% parsable by `flow-api-translator` and covered by `flow-api-test`. This diff increases test strictness to preserve this state going forward. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60377123
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Jul 30, 2024
Summary: Pull Request resolved: facebook#45786 Following D60377082, `packages/react-native/Libraries/` is now 100% parsable by `flow-api-translator` and covered by `flow-api-test`. This diff increases test strictness to preserve this state going forward. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60377123
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 2, 2024
Summary: Pull Request resolved: facebook#45786 Following D60377082, `packages/react-native/Libraries/` is now 100% parsable by `flow-api-translator` and covered by `flow-api-test`. This diff increases test strictness to preserve this state going forward. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60377123
huntie
force-pushed
the
export-D60377123
branch
from
beeaa7a
to
1d7afd2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Aug 8, 2024
Summary: Pull Request resolved: facebook#45786 Following D60377082, `packages/react-native/Libraries/` is now 100% parsable by `flow-api-translator` and covered by `flow-api-test`. This diff increases test strictness to preserve this state going forward. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60377123
huntie
force-pushed
the
export-D60377123
branch
from
1d7afd2
to
46f877c
Compare
…book#45783) Summary: Pull Request resolved: facebook#45783 Improves type strictness in the `react-native` package. - Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition. - Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present. - Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`). The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots). Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D60376327
Summary: Adds `flow` annotation, and/or adds minimal Flow types to remaining files under `packages/react-native/Libraries/`. As of this diff, 100% of this directory is now parsable by `flow-api-translator` and covered by `public-api-test`. Changelog: [Internal] Differential Revision: D60377082
Summary: Pull Request resolved: facebook#45786 Following D60377082, `packages/react-native/Libraries/` is now 100% parsable by `flow-api-translator` and covered by `flow-api-test`. This diff increases test strictness to preserve this state going forward. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60377123
|
This pull request was exported from Phabricator. Differential Revision: D60377123 |
huntie
force-pushed
the
export-D60377123
branch
from
46f877c
to
dd6c38b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Following D60377082,
packages/react-native/Libraries/is now 100% parsable byflow-api-translatorand covered byflow-api-test. This diff increases test strictness to preserve this state going forward.Changelog: [Internal]
Differential Revision: D60377123