New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break out URLSearchParams, require typedef for unparsable files #45783

Closed

huntie wants to merge 1 commit into facebook:main from huntie:export-D60376327

Member

huntie commented Jul 29, 2024

Summary:
Improves type strictness in the react-native package.

Break out URLSearchParams from URL.js into its own module, to isolate a $FlowFixMe[unsupported-syntax] suppression within that definition.
Update public-api-test to require an adjacent <module>.js.flow type definition file whenever a $FlowFixMe[unsupported-syntax]is present.
Add URLSearchParams.js.flow with a Flow parser compatible typedef (@iterator instead of [Symbol.iterator]).

The result of these changes is to add missing typedef test coverage for Libraries/Blob/URL.js (see updated test snapshots).

Changelog: [Internal]

Differential Revision: D60376327

facebook-github-bot added CLA Signed p: Facebook Partner labels

Contributor

facebook-github-bot commented Jul 29, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

facebook-github-bot added the fb-exported label

Collaborator

react-native-bot commented Jul 29, 2024

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 6224365

Contributor

facebook-github-bot commented Jul 29, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

ccae31e

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from 6224365 to ccae31e Compare

July 29, 2024 13:09

Collaborator

react-native-bot commented Jul 29, 2024

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against ccae31e

Contributor

facebook-github-bot commented Jul 30, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

4a98a88

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from ccae31e to 4a98a88 Compare

July 30, 2024 11:12

Collaborator

react-native-bot commented Jul 30, 2024

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against 4a98a88

Contributor

facebook-github-bot commented Aug 2, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

e4b4d22

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from 4a98a88 to e4b4d22 Compare

August 2, 2024 10:14

Collaborator

react-native-bot commented Aug 2, 2024

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against e4b4d22

Contributor

facebook-github-bot commented Aug 7, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

c9426d5

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from e4b4d22 to c9426d5 Compare

August 7, 2024 14:24

Collaborator

react-native-bot commented Aug 7, 2024

	Warnings
⚠️	🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS against c9426d5

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from c9426d5 to 458fe03 Compare

August 8, 2024 10:58

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

458fe03

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

81c94c1

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from 458fe03 to 81c94c1 Compare

August 8, 2024 12:17

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

d23c8e5

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from 81c94c1 to d23c8e5 Compare

August 8, 2024 13:28

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

5eeabeb

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie added a commit to huntie/react-native that referenced this pull request


          Break out URLSearchParams, require typedef for unparsable files (face…

f59f3ab

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from d23c8e5 to f59f3ab Compare

August 8, 2024 13:34


          Break out URLSearchParams, require typedef for unparsable files (face…

8be0ddf

…book#45783)

Summary:
Pull Request resolved: facebook#45783

Improves type strictness in the `react-native` package.

- Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
- Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
- Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).

The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).

Changelog: [Internal]

Reviewed By: hoxyq

Differential Revision: D60376327

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request was exported from Phabricator. Differential Revision: D60376327

huntie force-pushed the export-D60376327 branch from f59f3ab to 8be0ddf Compare

August 8, 2024 15:41

facebook-github-bot closed this in

51ffc5c

facebook-github-bot added the Merged label

Contributor

facebook-github-bot commented Aug 8, 2024

This pull request has been merged in 51ffc5c.

Collaborator

react-native-bot commented Aug 8, 2024

This pull request was successfully merged by @huntie in 51ffc5c

^{When will my fix make it into a release? | How to file a pick request?}

huntie deleted the export-D60376327 branch

September 9, 2024 12:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner