Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break out URLSearchParams, require typedef for unparsable files #45783

Closed
wants to merge 1 commit into from

Commits on Aug 8, 2024

  1. Break out URLSearchParams, require typedef for unparsable files (face…

    …book#45783)
    
    Summary:
    Pull Request resolved: facebook#45783
    
    Improves type strictness in the `react-native` package.
    
    - Break out `URLSearchParams` from `URL.js` into its own module, to isolate a `$FlowFixMe[unsupported-syntax]` suppression within that definition.
    - Update `public-api-test` to require an adjacent `<module>.js.flow` type definition file whenever a `$FlowFixMe[unsupported-syntax]`is present.
    - Add `URLSearchParams.js.flow` with a Flow parser compatible typedef (`@iterator` instead of `[Symbol.iterator]`).
    
    The result of these changes is to add missing typedef test coverage for `Libraries/Blob/URL.js` (see updated test snapshots).
    
    Changelog: [Internal]
    
    Reviewed By: hoxyq
    
    Differential Revision: D60376327
    huntie authored and facebook-github-bot committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8be0ddf View commit details
    Browse the repository at this point in the history