Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route all js errors caught in C++ through JsErrorHandler #45619

Closed
wants to merge 2 commits into from
Closed

Route all js errors caught in C++ through JsErrorHandler #45619

wants to merge 2 commits into from

Commits on Aug 13, 2024

  1. Refactor: RuntimeScheduler: Make error hander configurable 

    Summary:
## History
1. Originally landed in D60138415
2. Reverted in D60232011 (it broke ios oss builds)

## Motivation
In bridgeless, we want to configure the error handling of runtime scheduler. So that we can route those errors to the C++ error handling pipeline, when necessary.

Changelog: [Internal]

Differential Revision: D60477342
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    98b0c25 View commit details
    Browse the repository at this point in the history

  2. Route all js errors caught in C++ through JsErrorHandler (facebook#45619 

    )

Summary:
Pull Request resolved: facebook#45619

If any fatal js error is caught in c++, just route it through js error handler.

Then, make js error handler call into the right pipeline:
1. After the js pipeline is ready: Route the errors through the js pipeline
2. Otherwise: Route errors through the c++ pipeline.

Changelog: [Internal]

Reviewed By: javache

Differential Revision: D60138417
    @RSNara @facebook-github-bot
    RSNara authored and facebook-github-bot committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    64c6e1b View commit details
    Browse the repository at this point in the history