Route all js errors caught in C++ through JsErrorHandler #45619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D60138417 |
Summary: ## History 1. Originally landed in D60138415 2. Reverted in D60232011 (it broke ios oss builds) ## Motivation In bridgeless, we want to configure the error handling of runtime scheduler. So that we can route those errors to the C++ error handling pipeline, when necessary. Changelog: [Internal] Differential Revision: D60477342
|
This pull request was exported from Phabricator. Differential Revision: D60138417 |
RSNara
force-pushed
the
export-D60138417
branch
from
bc5c487
to
2e8ea71
Compare
|
This pull request was exported from Phabricator. Differential Revision: D60138417 |
RSNara
added a commit
to RSNara/react-native
that referenced
this pull request
Aug 13, 2024
) Summary: Pull Request resolved: facebook#45619 If any fatal js error is caught in c++, just route it through js error handler. Then, make js error handler call into the right pipeline: 1. After the js pipeline is ready: Route the errors through the js pipeline 2. Otherwise: Route errors through the c++ pipeline. Changelog: [Internal] Reviewed By: javache Differential Revision: D60138417
RSNara
force-pushed
the
export-D60138417
branch
from
2e8ea71
to
ff217c9
Compare
) Summary: Pull Request resolved: facebook#45619 If any fatal js error is caught in c++, just route it through js error handler. Then, make js error handler call into the right pipeline: 1. After the js pipeline is ready: Route the errors through the js pipeline 2. Otherwise: Route errors through the c++ pipeline. Changelog: [Internal] Reviewed By: javache Differential Revision: D60138417
|
This pull request was exported from Phabricator. Differential Revision: D60138417 |
RSNara
force-pushed
the
export-D60138417
branch
from
ff217c9
to
64c6e1b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If any fatal js error is caught in c++, just route it through js error handler.
Then, make js error handler call into the right pipeline:
Changelog: [Internal]
Differential Revision: D60138417