Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Bridgeless: Expose host delegate methods #44158

Closed
wants to merge 4 commits into from
Closed

[iOS] Bridgeless: Expose host delegate methods #44158

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fb5169
[iOS] Bridgeless: Expose host delegate methods
zhongwuzw Apr 19, 2024
73a19ba
favors composability over inheritance
zhongwuzw Apr 22, 2024
dd31921
Merge commit '03a51da727022d96f7f9bbc0840b1409121d0429' into features…
zhongwuzw Apr 22, 2024
de45aa8
Remove redundant code
zhongwuzw Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[iOS] Bridgeless: Expose host delegate methods
  • Loading branch information
@zhongwuzw
zhongwuzw committed Apr 19, 2024
commit 6fb5169de4b912a04a7aa7c810e5b4a20a02e1bb
18 changes: 16 additions & 2 deletions packages/react-native/Libraries/AppDelegate/RCTRootViewFactory.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ - (instancetype)initWithBundleURLBlock:(RCTBundleURLBlock)bundleURLBlock

@end

@interface RCTRootViewFactory () <RCTContextContainerHandling> {
@interface RCTRootViewFactory () <RCTContextContainerHandling, RCTHostDelegate> {
std::shared_ptr<const facebook::react::ReactNativeConfig> _reactNativeConfig;
facebook::react::ContextContainer::Shared _contextContainer;
}
Expand Down Expand Up @@ -181,6 +181,20 @@ - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge
return rootView;
}

#pragma mark - RCTHostDelegate

- (void)hostDidStart:(RCTHost *)host
{
}

- (void)host:(RCTHost *)host
didReceiveJSErrorStack:(NSArray<NSDictionary<NSString *, id> *> *)stack
message:(NSString *)message
exceptionId:(NSUInteger)exceptionId
isFatal:(BOOL)isFatal
{
}

#pragma mark - RCTCxxBridgeDelegate
- (std::unique_ptr<facebook::react::JSExecutorFactory>)jsExecutorFactoryForBridge:(RCTBridge *)bridge
{
Expand Down Expand Up @@ -234,7 +248,7 @@ - (void)createReactHostIfNeeded:(NSDictionary *)launchOptions

__weak __typeof(self) weakSelf = self;
_reactHost = [[RCTHost alloc] initWithBundleURLProvider:self->_configuration.bundleURLBlock
hostDelegate:nil
hostDelegate:self
turboModuleManagerDelegate:_turboModuleManagerDelegate
jsEngineProvider:^std::shared_ptr<facebook::react::JSRuntimeFactory>() {
return [weakSelf createJSRuntimeFactory];
Expand Down
Loading