-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iOS] Bridgeless: Expose host delegate methods #44158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @zhongwuzw, thanks for the PR! I think that the basic idea is very good, but as it is right now, it is not generally usable.
The RCTRootViewFactory
is an internal class and most users will not manipulate it directly, unless they are in a brownfield setup.
I think that a better approach would be to make it accept a HostDelegate object in the as init parameter (or as part of the configuration) and set that object as delegate for the the host (Also, this favors composability over inheritance, which is always good).
Then, we need to wire this up in the RCTAppDelegate
, somehow.
Base commit: 03a51da |
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
/rebase - this comment automatically rebase on top of main |
@cipolleschi merged this pull request in f500b47. |
This pull request was successfully merged by @zhongwuzw in f500b47. When will my fix make it into a release? | How to file a pick request? |
Summary: Expose host delegate methods that users can do some customize work. ## Changelog: [IOS] [ADDED] - Bridgeless: Expose host delegate methods Pull Request resolved: facebook#44158 Test Plan: Users can do some customized work by `RCTRootViewFactory`. Reviewed By: sammy-SC Differential Revision: D56521470 Pulled By: cipolleschi fbshipit-source-id: dd22d0978b9fd4385380945a514eb6596b7d874f
Summary:
Expose host delegate methods that users can do some customize work.
Changelog:
[IOS] [ADDED] - Bridgeless: Expose host delegate methods
Test Plan:
Users can do some customized work by
RCTRootViewFactory
.