Introduce "BoxShadowDrawable" for Android box shadows #43722
Closed
Commits on Apr 13, 2024
-
Decouple CSS background drawing from view, New Commit
Differential Revision: D55565035
-
react-native] Allow sigma blur without filter prop
Differential Revision: D55563775
-
Cleanup border radius resolution
Differential Revision: D55635743
-
Introduce "BoxShadowDrawable" for Android box shadows (facebook#43722)
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D55561465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.