Introduce "BoxShadowDrawable" for Android box shadows #43722
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 1, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
0fc42d5
to
a163191
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
a163191
to
112b690
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: joevilches Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
112b690
to
8d42c41
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
8d42c41
to
bb3ce99
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
bb3ce99
to
2b0c0c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
2b0c0c8
to
5dd5c6e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
force-pushed
the
export-D55561465
branch
from
5dd5c6e
to
42bcbea
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465
Base commit: 1b152f6 |
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 8, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
42bcbea
to
c0037ad
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D55561465
NickGerleman
force-pushed
the
export-D55561465
branch
from
c0037ad
to
e8bee5e
Compare
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465 Reviewed By: joevilches
NickGerleman
added a commit
to NickGerleman/react-native
that referenced
this pull request
Apr 9, 2024
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Differential Revision: D55561465 Reviewed By: joevilches
Differential Revision: D55565035
Differential Revision: D55563775
Differential Revision: D55635743
Summary: Pull Request resolved: facebook#43722 This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android `RenderNode` and `RenderEffect` APIs provided by API 31. Inset box shadows can also be added using a similar method, but this is not done yet. The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up. Changelog: [Internal] Reviewed By: javache, cortinico Differential Revision: D55561465
|
This pull request was exported from Phabricator. Differential Revision: D55561465 |
NickGerleman
force-pushed
the
export-D55561465
branch
from
e8bee5e
to
90f1fba
Compare
|
This pull request has been merged in 314a919. |
|
this is amazing! nice work nick! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a drawable, when when drawn on the bounds of a border-box sized view, will draw a spec compliant box-shadow outside the box. This is reliant on Android
RenderNodeandRenderEffectAPIs provided by API 31.Inset box shadows can also be added using a similar method, but this is not done yet.
The code which manages this is in flux, but the underlying drawable should be good. Will add some tests once it's more wired up.
Test Plan
Below applies a
5pxblackspread with a10pxblur to the purple view which includes a border radius. Other combinations of offsets, spreads, and blur radii were tested.When I did this inside of the existing filters test (top has filter applied), it highlighted an issue of clipping content outside of filtered area, which will not be related directly to this change.
Changelog: [Internal]
Differential Revision: D55561465