fix: defer ReactDevToolsOverlay import #43690
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: # Changelog: [Internal] Fixes facebook#43678. The issue is that once `getInspectorDataForViewAtPoint` is imported, it should throw if RDT global hook was not injected. ReactDevTools overlay imports `getInspectorDataForViewAtPoint`, this is why it did throw in testing environment. ReactDevToolsOverlay JSX-element is already gated with RDT global hook check, adding a deferred import, same as it was already implemented for Inspector. Still unclear to me how this didn't throw all this time while using the Catalyst / RNTester. Differential Revision: D55474774
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55474774 |
Contributor
|
This pull request has been merged in 4841373. |
huntie
pushed a commit
that referenced
this pull request
Apr 2, 2024
Summary: Pull Request resolved: #43690 # Changelog: [Internal] Fixes #43678. The issue is that once `getInspectorDataForViewAtPoint` is imported, it should throw if RDT global hook was not injected. ReactDevTools overlay imports `getInspectorDataForViewAtPoint`, this is why it did throw in testing environment. ReactDevToolsOverlay JSX-element is already gated with RDT global hook check, adding a deferred import, same as it was already implemented for Inspector. Still unclear to me how this didn't throw all this time while using the Catalyst / RNTester. Reviewed By: cortinico Differential Revision: D55474774 fbshipit-source-id: 759e5e8227cc7534193e5b95616b6099c15f5cb5
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Fixes #43678.
The issue is that once
getInspectorDataForViewAtPointis imported, it should throw if RDT global hook was not injected. ReactDevTools overlay importsgetInspectorDataForViewAtPoint, this is why it did throw in testing environment.ReactDevToolsOverlay JSX-element is already gated with RDT global hook check, adding a deferred import, same as it was already implemented for Inspector.
Still unclear to me how this didn't throw all this time while using the Catalyst / RNTester.
Differential Revision: D55474774