Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix & Instruction of adding manual native package #41985

Conversation

aajahid
Copy link

@aajahid aajahid commented Dec 19, 2023

Proper Kotlin syntax and instruction on how to add native package manually.
I followed the official documentation and applied the "Kotlin" syntax. I believe it had the leftover comment/instruction of java syntax, which I replaced with Kotlin syntax.

Summary:

The comment/instruction on manual native package isn't correct. Also the existing code isn't intuitive for developer to easily add a native package manually.

Changelog:

[ANDROID] [CHANGED] - Allowed developer easily add a native package manually, with proper instruction.

Test Plan:

Applied the change from the official docs - https://reactnative.dev/docs/native-modules-android?android-language=kotlin
Also in my own project - I was able to add native package manually using that syntax.
image

Proper Kotlin syntax and instruction on how to add native package manually
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 19, 2023
changed the tab into 2 spaces.
@aajahid aajahid marked this pull request as ready for review December 19, 2023 06:42
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,525,132 -8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,899,938 +5
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 43826fa
Branch: main

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 19, 2023
@aajahid
Copy link
Author

aajahid commented Dec 28, 2023

Closing as already another PR with same fix got merged.

#41856

@aajahid aajahid closed this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants