Fix & Instruction of adding manual native package #41985
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper Kotlin syntax and instruction on how to add native package manually.
I followed the official documentation and applied the "Kotlin" syntax. I believe it had the leftover comment/instruction of java syntax, which I replaced with Kotlin syntax.
Summary:
The comment/instruction on manual native package isn't correct. Also the existing code isn't intuitive for developer to easily add a native package manually.
Changelog:
[ANDROID] [CHANGED] - Allowed developer easily add a native package manually, with proper instruction.
Test Plan:
Applied the change from the official docs - https://reactnative.dev/docs/native-modules-android?android-language=kotlin
Also in my own project - I was able to add native package manually using that syntax.