Skip to content

Commit

Permalink
fix(rn-tester): add missing params when running Android app from watc…
Browse files Browse the repository at this point in the history
…h mode (#41979)

Summary:
Passed `--mode HermesDebug` to `run-android` command when running from watch mode by pressing `a` on terminal running a dev server. The flag is the same as in the `package.json`:
https://github.com/facebook/react-native/blob/27f38f6f0647ec1809ee0a0d8e9da3a77a9115b1/packages/rn-tester/package.json#L17

## Changelog:

[INTERNAL] [CHANGED] - Add missing params when running Android app from watch mode by pressing `a`

Pull Request resolved: #41979

Test Plan: Run `yarn start` press `a` in the watch mode, and Android app should be build and launch correctly.

Reviewed By: cipolleschi

Differential Revision: D52265462

Pulled By: lunaleaps

fbshipit-source-id: b2fbe6c889d8067876e160a8ce64dedcc4ce24d7
  • Loading branch information
szymonrybczak authored and facebook-github-bot committed Dec 18, 2023
1 parent 27f38f6 commit 43826fa
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/rn-tester/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ module.exports = {
manifestPath:
'packages/rn-tester/android/app/src/main/AndroidManifest.xml',
packageName: 'com.facebook.react.uiapp',
watchModeCommandParams: ['--mode HermesDebug'],
},
},
};

0 comments on commit 43826fa

Please sign in to comment.