Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update profiler button to use "Toggle" string. #41900

Closed
wants to merge 1 commit into from
Closed

Update profiler button to use "Toggle" string. #41900

wants to merge 1 commit into from

Conversation

szymonrybczak
Copy link
Contributor

Summary:

Fixes #38192, this issue wasn't fixed properly, @cortinico fixed same case but for inspector button.

Changelog:

[ANDROID] [FIXED] - Update profiler button to use "Toggle" string.

Test Plan:

CI

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Callstack Partner: Callstack Partner labels Dec 11, 2023
@szymonrybczak
Copy link
Contributor Author

Thanks to @fnwk for spotting this!

@facebook-github-bot facebook-github-bot added the Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. label Dec 11, 2023
@facebook-github-bot
Copy link
Contributor

@ryancat has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,512,540 -4,576
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 19,891,367 -4,570
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ca9b6b5
Branch: main

@github-actions GitHub Actions
Copy link

This pull request was successfully merged by @szymonrybczak in 8bcaed9.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Dec 12, 2023
@szymonrybczak szymonrybczak deleted the fix/toggle-lable branch December 12, 2023 11:17
Othinn pushed a commit to Othinn/react-native that referenced this pull request Jan 9, 2024
@szymonrybczak @Othinn
Update profiler button to use "Toggle" string. (facebook#41900)
c3180ac 
Summary:
Fixes facebook#38192, this issue wasn't fixed properly, cortinico fixed same case but for inspector button.

## Changelog:

[ANDROID] [FIXED] - Update profiler button to use "Toggle" string.

Pull Request resolved: facebook#41900

Test Plan: CI

Reviewed By: cortinico

Differential Revision: D52049181

Pulled By: ryancat

fbshipit-source-id: 9225edb3a5a582b879f4ebb835f6ac52cba4c042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Callstack Partner: Callstack Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dev Menu button is not updating label properly
4 participants
@szymonrybczak @facebook-github-bot @analysis-bot @cortinico