-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev Menu button is not updating label properly #38192
Labels
Comments
This is a known issue, thanks for reporting it @szymonrybczak |
This was fixed recently on main 0cbd2a3 |
facebook-github-bot
pushed a commit
that referenced
this issue
Dec 12, 2023
Summary: Fixes #38192, this issue wasn't fixed properly, cortinico fixed same case but for inspector button. ## Changelog: [ANDROID] [FIXED] - Update profiler button to use "Toggle" string. Pull Request resolved: #41900 Test Plan: CI Reviewed By: cortinico Differential Revision: D52049181 Pulled By: ryancat fbshipit-source-id: 9225edb3a5a582b879f4ebb835f6ac52cba4c042
Othinn
pushed a commit
to Othinn/react-native
that referenced
this issue
Jan 9, 2024
Summary: Fixes facebook#38192, this issue wasn't fixed properly, cortinico fixed same case but for inspector button. ## Changelog: [ANDROID] [FIXED] - Update profiler button to use "Toggle" string. Pull Request resolved: facebook#41900 Test Plan: CI Reviewed By: cortinico Differential Revision: D52049181 Pulled By: ryancat fbshipit-source-id: 9225edb3a5a582b879f4ebb835f6ac52cba4c042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
When pressing "Enable Sampling Profiler" on Android, it should change the label to "Disable Sampling Profiler", but it doesn't.
React Native Version
0.72.1
Output of
npx react-native info
System:
OS: macOS 13.3.1
CPU: (8) arm64 Apple M1 Pro
Memory: 106.09 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 16.18.1
path: ~/.nvm/versions/node/v16.18.1/bin/node
Yarn:
version: 1.22.19
path: ~/.nvm/versions/node/v16.18.1/bin/yarn
npm:
version: 9.7.2
path: ~/.nvm/versions/node/v16.18.1/bin/npm
Watchman:
version: 2023.06.08.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /Users/szymonrybczak/.rbenv/shims/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK:
API Levels:
- "28"
- "30"
- "31"
- "33"
- "33"
Build Tools:
- 30.0.3
- 33.0.0
- 34.0.0
System Images:
- android-33 | Google APIs ARM 64 v8a
- android-TiramisuPrivacySandbox | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode:
version: 14.3/14E222b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 19.0.2
path: /usr/bin/javac
Ruby:
version: 2.7.6
path: /Users/szymonrybczak/.rbenv/shims/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"react-native": Not Found
Android:
hermesEnabled: false
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
Steps to reproduce
npx react-native@latest init App
.npx react-native run-android
.d
inside terminal."Disable Sampling Profiler" button should be visible instead of "Enable Sampling Profiler".
Snack, code example, screenshot, or link to a repository
CleanShot.2023-07-05.at.10.47.04.mp4
The text was updated successfully, but these errors were encountered: