Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor[AppContainer]: remove innerView ref from state #41613

Closed
wants to merge 3 commits into from
Closed

refactor[AppContainer]: remove innerView ref from state #41613

wants to merge 3 commits into from

Commits on Nov 22, 2023

  1. feat[TraceUpdateOverlay]: add iOS native component (facebook#41563) 

    Summary:

Changelog:
[iOS][Added] - support "highlighting updates when components render" feature from React DevTools

Differential Revision: D51470012
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c5aa184 View commit details
    Browse the repository at this point in the history

  2. refactor: TraceUpdates native component -> DebuggingOverlay (facebook… 

    …#41562)

Summary:

Changelog: [Internal]

We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools.

Differential Revision: D51470789
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    c26d2fe View commit details
    Browse the repository at this point in the history

  3. refactor[AppContainer]: remove innerView ref from state 

    Summary:
We were keeping ref in the AppContainer's state before migrating these components to functions.

We actually need a real ref here, so we can use `useImperativeHandle` on it later. These refs will be passed as an argument for DebuggingRegistry subscription, whichi will call them on all necessary AppContainers to highlight required components.

Differential Revision: D51536772
    @facebook-github-bot
    Ruslan Lesiutin authored and facebook-github-bot committed Nov 22, 2023
    Configuration menu
    Copy the full SHA
    e057450 View commit details
    Browse the repository at this point in the history