refactor[AppContainer]: remove innerView ref from state #41613
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 22, 2023 13:44
Summary: Changelog: [iOS][Added] - support "highlighting updates when components render" feature from React DevTools Differential Revision: D51470012
…#41562) Summary: Changelog: [Internal] We will use this native component as a single layer for drawing debugging information: both for trace updates and inspected components from React DevTools. Differential Revision: D51470789
Summary: We were keeping ref in the AppContainer's state before migrating these components to functions. We actually need a real ref here, so we can use `useImperativeHandle` on it later. These refs will be passed as an argument for DebuggingRegistry subscription, whichi will call them on all necessary AppContainers to highlight required components. Differential Revision: D51536772
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51536772 |
Base commit: d4399c5 |
|
This pull request has been merged in b71bb81. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41613 Changelog: [Internal] We were keeping ref in the AppContainer's state before migrating these components to functions. We actually need a real ref here, so we can use `useImperativeHandle` on it later. These refs will be passed as an argument for DebuggingRegistry subscription, whichi will call them on all necessary AppContainers to highlight required components. Reviewed By: javache Differential Revision: D51536772 fbshipit-source-id: d49035874ce3c9b1acf08d5ab666886f68e6f40e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We were keeping ref in the AppContainer's state before migrating these components to functions.
We actually need a real ref here, so we can use
useImperativeHandleon it later. These refs will be passed as an argument for DebuggingRegistry subscription, whichi will call them on all necessary AppContainers to highlight required components.Differential Revision: D51536772