Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue where absolute children of row-reverse containers would inset on the wrong side #41293

Closed
wants to merge 3 commits into from
Closed

Fix issue where absolute children of row-reverse containers would inset on the wrong side #41293

wants to merge 3 commits into from

Commits on Nov 7, 2023

  1. Simplify getting padding + border for cross axis in algorithm (facebo… 

    …ok#41208)

Summary:
X-link: facebook/yoga#1437


Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner

Reviewed By: NickGerleman

Differential Revision: D50704177
    @facebook-github-bot
    Joe Vilches authored and facebook-github-bot committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c313b26 View commit details
    Browse the repository at this point in the history

  2. Introduce isDefined() and remove cases of !isUndefined() (facebook#41209 

    )

Summary:

X-link: facebook/yoga#1439

There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted.

This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read.

Reviewed By: NickGerleman

Differential Revision: D50705523
    @facebook-github-bot
    Joe Vilches authored and facebook-github-bot committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    12c7eaa View commit details
    Browse the repository at this point in the history

  3. Fix issue where absolute children of row-reverse containers would ins… 

    …et on the wrong side (facebook#41293)

Summary:

X-link: facebook/yoga#1446

NickGerleman pointed out that my recent changes to fix the slew of row-reverse problems in Yoga actually ended up regressing some parts. Specifically, absolute children of row-reverse containers would have their insets set to the wrong side. So if you set left: 10 it would apply it to the right.

Turns out, in `layoutAbsoluteChild` there were cases where we were applying inlineStart/End values to the flexStart/End edge, which can never be right. So I changed the values to also be flexStart/End as the fix here.

Reviewed By: NickGerleman

Differential Revision: D50945475
    @joevilches @facebook-github-bot
    joevilches authored and facebook-github-bot committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    91b47c3 View commit details
    Browse the repository at this point in the history