Introduce isDefined() and remove cases of !isUndefined()#41209
Closed
joevilches wants to merge 2 commits into
Closed
Introduce isDefined() and remove cases of !isUndefined()#41209joevilches wants to merge 2 commits into
joevilches wants to merge 2 commits into
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
Base commit: d11d5f3 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Oct 27, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Differential Revision: D50705523
joevilches
force-pushed
the
export-D50705523
branch
from
9822a31 to
13bc22c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 2, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
force-pushed
the
export-D50705523
branch
from
13bc22c to
a6e8474
Compare
joevilches
force-pushed
the
export-D50705523
branch
from
a6e8474 to
6f79ecf
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
force-pushed
the
export-D50705523
branch
from
6f79ecf to
6636504
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
force-pushed
the
export-D50705523
branch
from
6636504 to
ab79879
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 3, 2023
Summary: X-link: facebook/react-native#41209 Pull Request resolved: facebook#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: 458ca7567d440b8f795a82c45fccd2043df4f790
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 6, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
joevilches
force-pushed
the
export-D50705523
branch
from
ab79879 to
b97e987
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
joevilches
force-pushed
the
export-D50705523
branch
from
a30a62b to
12a1f81
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
joevilches
force-pushed
the
export-D50705523
branch
from
12a1f81 to
12c7eaa
Compare
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 Pull Request resolved: facebook#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: 4bd43c0a0910aca15e082d64c0843823a5de853f
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 Pull Request resolved: facebook#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: 5fc2608c2200f2db5ee28e424900375a3c4c239d
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
joevilches
force-pushed
the
export-D50705523
branch
from
12c7eaa to
a4ea836
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
NickGerleman
pushed a commit
to NickGerleman/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 Pull Request resolved: facebook#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: df31c5ec14c32cb239c1953912cc30edec6b3b33
added 2 commits
November 7, 2023 03:23
…ok#41208) Summary: X-link: facebook/yoga#1437 Reading through the sizing logic and this seemed a bit redundant/confusing. Lets use the same function we just used for the main axis for the cross axis as well so people do not think its special. Also we will need one less variable. The reason this was done it seems is because we need the leading padding + border elsewhere so this is technically a few less steps but this is cleaner Reviewed By: NickGerleman Differential Revision: D50704177
) Summary: X-link: facebook/yoga#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523
joevilches
force-pushed
the
export-D50705523
branch
from
a4ea836 to
e642d26
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50705523 |
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 X-link: facebook/yoga#1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: edc7d3f2cbbae38ddaeb2030a419320caf73feff
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Nov 7, 2023
Summary: X-link: facebook/react-native#41209 Pull Request resolved: #1439 There are so many instances in this code base where we use the double negative of `!yoga::isUndefined(<something>)`. This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like `!longVariableName.longFunctionName(longArgumentName).isUndefined()` and it is hard to see that this undefined is inverted. This just replaces all instances of inverted `isUndefined()` with `isDefined()` so its easier to read. Reviewed By: NickGerleman Differential Revision: D50705523 fbshipit-source-id: edc7d3f2cbbae38ddaeb2030a419320caf73feff
Contributor
|
This pull request has been merged in 3b13d3c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
There are so many instances in this code base where we use the double negative of
!yoga::isUndefined(<something>). This is not as easy to read since because of this double negative imo. Additionally, sometimes we have really long chains like!longVariableName.longFunctionName(longArgumentName).isUndefined()and it is hard to see that this undefined is inverted.This just replaces all instances of inverted
isUndefined()withisDefined()so its easier to read.Differential Revision: D50705523