Wire up configuration to use microtasks in RuntimeScheduler, Hermes and React #41090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
force-pushed
the
export-D50177355
branch
from
bad7748
to
548a9d2
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
548a9d2
to
24885d1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
24885d1
to
ce724fb
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
ce724fb
to
40adcba
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
40adcba
to
b6fcd74
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
Base commit: 79d620d |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
b6fcd74
to
84c21bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
84c21bf
to
adab559
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
adab559
to
f5fe9b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
Summary: Adds support for executing microtasks in `RuntimeScheduler`, the same way we did in `JSIExecutor` before (removed in D49536251 / facebook#40870) but now after each actual task in the scheduler. When we use microtasks in the scheduler, we ignore calls to execute expired tasks (which was used to call "React Native microtasks" that we had before). Those should now be regular microtasks in the runtime. This is gated behind a feature flag until we've tested this broadly. This is going to be tested in Hermes but we need to add support for microtasks in JSC (which has a no-op in its JSI interface). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D49536262
…nd React (facebook#41090) Summary: This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355
rubennorte
force-pushed
the
export-D50177355
branch
from
f5fe9b2
to
a34a9cf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50177355 |
|
This pull request has been merged in 1923a4e. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
…nd React (facebook#41090) Summary: Pull Request resolved: facebook#41090 This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes. Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50177355 fbshipit-source-id: 6cf23cf72b63d19f50453d3e4cc4ac1b056dbd92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This propagates to enable the use of microtasks in the React reconciler, Runtime Scheduler and Hermes.
Changelog: [internal]
Differential Revision: D50177355
See react-native-community/discussions-and-proposals#744