Pass reactNativeConfig to HermesInstance when not using the native module version #41082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubennorte
force-pushed
the
export-D50450488
branch
2 times, most recently
from
a3a153e
to
c8b0a66
Compare
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
force-pushed
the
export-D50450488
branch
from
c8b0a66
to
c59952c
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
c59952c
to
f116599
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
f116599
to
4f1f22e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
4f1f22e
to
66817c1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
66817c1
to
9311e6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
9311e6d
to
911fca5
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
Base commit: 79d620d |
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
911fca5
to
4453826
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
4453826
to
b7cddf7
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Oct 23, 2023
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
b7cddf7
to
7dfce4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
…dule version (facebook#41082) Summary: We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488
rubennorte
force-pushed
the
export-D50450488
branch
from
7dfce4e
to
480335e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D50450488 |
|
This pull request has been merged in 4bf96f1. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
…dule version (facebook#41082) Summary: Pull Request resolved: facebook#41082 We're testing a method to access `ReactNativeConfig` without a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler. When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355). Changelog: [internal] Reviewed By: sammy-SC Differential Revision: D50450488 fbshipit-source-id: 77f0369f93bb7175c569d51b0569669552a13acf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We're testing a method to access
ReactNativeConfigwithout a dependency on native modules, so we can access it before that infra is initialized in places like Hermes or RuntimeScheduler.When we're in that variant, this passes the configuration to Hermes so we can use it to set flags in the runtime (like enabling microtasks in D50177355).
Changelog: [internal]
Differential Revision: D50450488