Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RAIICallbackWrapperDestroyer with AsyncCallback #39952

Closed
wants to merge 1 commit into from
Closed

Replace RAIICallbackWrapperDestroyer with AsyncCallback #39952

wants to merge 1 commit into from

Commits on Oct 11, 2023

  1. Replace RAIICallbackWrapperDestroyer with AsyncCallback (facebook#39952) 

    Summary:

AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases.

Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership.

Reviewed By: RSNara

Differential Revision: D49792717
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    7d98e90 View commit details
    Browse the repository at this point in the history