Replace RAIICallbackWrapperDestroyer with AsyncCallback #39952
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49792717 |
Base commit: 3859eee |
|
This pull request was exported from Phabricator. Differential Revision: D49792717 |
javache
force-pushed
the
export-D49792717
branch
from
4934d66
to
e517072
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 9, 2023
Summary: Pull Request resolved: facebook#39952 AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases. Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership. Differential Revision: D49792717 fbshipit-source-id: ffe9e3de79d3f60d064e758e1bd2eaa0e9aa5547
|
This pull request was exported from Phabricator. Differential Revision: D49792717 |
javache
force-pushed
the
export-D49792717
branch
from
e517072
to
6b40a88
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 10, 2023
Summary: Pull Request resolved: facebook#39952 AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases. Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership. Differential Revision: D49792717 fbshipit-source-id: c0c3e6d69d324199ec985699ea6cba4d174d9da9
javache
added a commit
to javache/react-native
that referenced
this pull request
Oct 11, 2023
Summary: AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases. Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership. Reviewed By: RSNara Differential Revision: D49792717
javache
force-pushed
the
export-D49792717
branch
from
6b40a88
to
7032e4e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49792717 |
Summary: AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases. Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership. Reviewed By: RSNara Differential Revision: D49792717
javache
force-pushed
the
export-D49792717
branch
from
7032e4e
to
7d98e90
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49792717 |
|
This pull request has been merged in 8dd89ce. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
AsyncCallback and SyncCallbacks are better primitives for jsi::Function handling. The code is simpler and requires less manual argument passing. See in D49684248 how the API was extended to support more use-cases.
Changelog: [General] Deprecated RAIICallbackWrapperDestroyer. Use AsyncCallback instead for safe jsi::Function memory ownership.
Differential Revision: D49792717