Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce visibility of TurboModulePerfLogger to pacakge #39340

Closed
wants to merge 9 commits into from

Conversation

mdvacca
Copy link
Contributor

@mdvacca mdvacca commented Sep 7, 2023

Summary:
Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Differential Revision: D49077068

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Sep 7, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

@analysis-bot
Copy link

analysis-bot commented Sep 7, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,323,607 -194
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,562,605 +103
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 59e6b11
Branch: main

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 32201f1a414e4bd7e03156b8d435fc08e04f7272
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: db271eb3dc651bc168520debaebc188237d89d36
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 85ffdbf97a6370dc520fbad35739889a71ed9382
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 8, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 39bf5a6ed7ce73f479e5ac724522eeb1f6ee319f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 11, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 10b927456176a0ff35436ed1210c73a8941e8c0f
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 156b52cc1099d7bdb780d8264605750b46e58049
@github-actions
Copy link

github-actions bot commented Sep 13, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 06432b0

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 13, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 985fdc4e690928a084b85304174b2122ed0a653a
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

mdvacca added a commit to mdvacca/react-native that referenced this pull request Sep 14, 2023
Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: abe971ffe1929194760981ae1ab33361c7183571
Differential Revision: D48992474

fbshipit-source-id: 9e1eaa30b3c1a246cbe40bab1e35d602eb283ea3
Differential Revision: D48992720

fbshipit-source-id: b3675ed66493727f8b0405595cfd507f62b8b664
Summary:
In this diff I'm introducing the new DeprecatedInNewArchitecture annotation, the goal of this annotation is to describe that a class or method will be deprecated when the new architecture of react native is fully rolled out in
OSS.

changelog: [Android] Introduce DeprecatedInNewArchitecture annotation

Differential Revision: D49068234

fbshipit-source-id: 367ffa22c8df25d781d82c91fe681bf02c0f5ca2
…le instead

Differential Revision: D48992719

fbshipit-source-id: fca8545c10a307feab20e85794699a507e9707f4
Summary:
Mark ReactPackage.getModule as UnstableReactNativeAPI

changelog: [internal] internal

Differential Revision: D49068233

fbshipit-source-id: f3e9ec06d275a78f2080768c7cd3942752f25ff5
Summary:
Fix lint warning in MainReactPackage, as reactModule could be null

changelog: [internal] internal

Differential Revision: D49077064

fbshipit-source-id: 1a14c89669668553cdbdd6d2aeeb7707b0a6c7fc
Summary:
Annotate HybridData with DoNotStrip

changelog: [intenral] internal

Differential Revision: D49077065

fbshipit-source-id: 6a80809726b31f7ef979e1d41f201a8172ba2a4f
Summary:
Reduce visibility of TurboModuleInteropUtils to package only

changelog: [intenral] internal

Differential Revision: D49077066

fbshipit-source-id: f1535c501b67a04e61e2717162544b93bf61b454
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49077068

Summary:
Pull Request resolved: facebook#39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: 8a2494e8d21bdee6c6073e697d72f6b7a09f1826
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in eba05a5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants