Skip to content

Commit

Permalink
Reduce visibility of TurboModulePerfLogger to pacakge (#39340)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #39340

Reduce visibility of TurboModulePerfLogger to pacakge and remove some lint warns

changelog: [intenral] internal

Reviewed By: christophpurrer

Differential Revision: D49077068

fbshipit-source-id: db271eb3dc651bc168520debaebc188237d89d36
  • Loading branch information
mdvacca committed Sep 8, 2023
1 parent c0caae2 commit da02697
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,16 @@ public List<String> getEagerInitModuleNames() {
return mEagerInitModuleNames;
}

// used from TurboModuleManager.cpp
@SuppressWarnings("unused")
@DoNotStrip
private static List<TurboModuleInteropUtils.MethodDescriptor> getMethodDescriptorsFromModule(
NativeModule module) {
return TurboModuleInteropUtils.getMethodDescriptorsFromModule(module);
}

// used from TurboModuleManager.cpp
@SuppressWarnings("unused")
@DoNotStrip
@Nullable
private NativeModule getLegacyJavaModule(String moduleName) {
Expand All @@ -150,6 +154,7 @@ private NativeModule getLegacyJavaModule(String moduleName) {
: null;
}

// used from TurboModuleManager.cpp
@SuppressWarnings("unused")
@DoNotStrip
@Nullable
Expand All @@ -173,6 +178,7 @@ private CxxModuleWrapper getLegacyCxxModule(String moduleName) {
: null;
}

// used from TurboModuleManager.cpp
@SuppressWarnings("unused")
@DoNotStrip
@Nullable
Expand All @@ -195,6 +201,8 @@ private CxxModuleWrapper getTurboLegacyCxxModule(String moduleName) {
: null;
}

// used from TurboModuleManager.cpp
@SuppressWarnings("unused")
@DoNotStrip
@Nullable
private TurboModule getTurboJavaModule(String moduleName) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import javax.annotation.Nullable;

@DoNotStrip
public class TurboModulePerfLogger {
class TurboModulePerfLogger {

@Nullable private static NativeModulePerfLogger sNativeModulePerfLogger = null;

Expand Down

0 comments on commit da02697

Please sign in to comment.