Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize arg conversion in SurfaceRegistryBinding #39094

Closed
wants to merge 1 commit into from
Closed

Optimize arg conversion in SurfaceRegistryBinding #39094

wants to merge 1 commit into from

Commits on Aug 22, 2023

  1. Optimize arg conversion in SurfaceRegistryBinding (facebook#39094) 

    Summary:
Pull Request resolved: facebook#39094

We can construct the outer jsi::Object directly instead of going through `valueFromDynamic` for the whole thing.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D48519751

fbshipit-source-id: da2279c1f4147999c1c80a5b84ac5074487402df
    @javache @facebook-github-bot
    javache authored and facebook-github-bot committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    8b2843c View commit details
    Browse the repository at this point in the history