Optimize arg conversion in SurfaceRegistryBinding #39094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base commit: 4f8a8ce |
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48519751 |
javache
force-pushed
the
export-D48519751
branch
from
c7d9438
to
15ba4a4
Compare
javache
added a commit
to javache/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39094 We can construct the outer jsi::Object directly instead of going through `valueFromDynamic` for the whole thing. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48519751 fbshipit-source-id: 0287c22d0c966612b9af4c40b460e07fed2f1f2b
Summary: Pull Request resolved: facebook#39094 We can construct the outer jsi::Object directly instead of going through `valueFromDynamic` for the whole thing. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D48519751 fbshipit-source-id: da2279c1f4147999c1c80a5b84ac5074487402df
|
This pull request was exported from Phabricator. Differential Revision: D48519751 |
javache
force-pushed
the
export-D48519751
branch
from
15ba4a4
to
8b2843c
Compare
|
This pull request was successfully merged by @javache in c22cc8f. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We can construct the outer jsi::Object directly instead of going through
valueFromDynamicfor the whole thing.Changelog: [Internal]
Reviewed By: sammy-SC
Differential Revision: D48519751