make notch detection more future proof #38940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
Base commit: 7cd6996 |
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38940 ## Changelog: [Internal] - make notch detection more future proof current implementation of `isIPhoneX_deprecated` is not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out. Differential Revision: D48254737 fbshipit-source-id: 2e36c468e4ac625599b4ddac3768ade8b7d76221
philIip
force-pushed
the
export-D48254737
branch
from
2253cb3 to
2a1eb5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
philIip
force-pushed
the
export-D48254737
branch
from
2a1eb5e to
cb9ec91
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38940 ## Changelog: [Internal] - make notch detection more future proof current implementation of `isIPhoneX_deprecated` is not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out. Reviewed By: cipolleschi Differential Revision: D48254737 fbshipit-source-id: d75ec8fa543080f6488f2f07923462e71c5511d8
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38940 ## Changelog: [Internal] - make notch detection more future proof current implementation of `isIPhoneX_deprecated` is not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out. Reviewed By: cipolleschi Differential Revision: D48254737 fbshipit-source-id: 5063fb66a965e31841d6baa375ab6f63cda37b39
philIip
force-pushed
the
export-D48254737
branch
from
cb9ec91 to
67a2548
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 11, 2023
Summary: Pull Request resolved: facebook#38940 ## Changelog: [Internal] - make notch detection more future proof current implementation of `isIPhoneX_deprecated` is not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out. Reviewed By: cipolleschi Differential Revision: D48254737 fbshipit-source-id: 79f88ded9ab56fa2ae50f48bfddaf6d55c37de63
philIip
force-pushed
the
export-D48254737
branch
from
67a2548 to
9cfd367
Compare
Summary: Pull Request resolved: facebook#38940 ## Changelog: [Internal] - make notch detection more future proof current implementation of `isIPhoneX_deprecated` is not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out. Reviewed By: cipolleschi Differential Revision: D48254737 fbshipit-source-id: 4bbb1cb3b9a4248e44dc43db65b3dd8b017a67ac
|
This pull request was exported from Phabricator. Differential Revision: D48254737 |
philIip
force-pushed
the
export-D48254737
branch
from
9cfd367 to
396b70d
Compare
|
This pull request has been merged in 6d822b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - make notch detection more future proof
current implementation of
isIPhoneX_deprecatedis not completely correct and is already 2 iphones behind. i update the implementation so we don't have to change it with every new iphone that comes out.Differential Revision: D48254737