Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isIPhoneX_deprecated #32853

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove isIPhoneX_deprecated #32853

wants to merge 1 commit into from

Conversation

ken0nek
Copy link
Contributor

@ken0nek ken0nek commented Jan 8, 2022 •
edited
Loading

Summary

Remove a deprecated property isIPhoneX

[iOS] [Removed] - Remove isIPhoneX

Test Plan

Visual

Warning

Screen Shot 2022-01-07 at 7 01 58 PM

props.level === 'syntax' (simulated)

Screen Shot 2022-01-07 at 8 38 55 PM

Changelog

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Jan 8, 2022
ken0nek
ken0nek commented Jan 8, 2022
View reviewed changes
Libraries/LogBox/UI/LogBoxInspectorFooter.js
);
}

return (
<View style={styles.root}>
<SafeAreaView style={styles.root}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment for isIPhoneX

 // Note:
 // This prop is deprecated and will be removed in a future release.
 // Please use this only for a quick and temporary solution.
 // Use <SafeAreaView> instead.

@analysis-bot
Copy link

analysis-bot commented Jan 8, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 7dc0b51
Branch: main

@analysis-bot
Copy link

analysis-bot commented Jan 8, 2022 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,796,733 +0
android hermes armeabi-v7a 7,199,920 +0
android hermes x86 8,107,568 +0
android hermes x86_64 8,087,286 +0
android jsc arm64-v8a 9,669,492 +0
android jsc armeabi-v7a 8,441,438 +0
android jsc x86 9,620,936 +0
android jsc x86_64 10,217,822 +0

Base commit: 7dc0b51
Branch: main

@facebook-github-bot
Copy link
Contributor

@sota000 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@sota000
Copy link
Contributor

sota000 commented Jan 20, 2022

There is internal usages for this property, and we won't be able to delete the property just yet.

@ken0nek ken0nek force-pushed the work/remove-isIPhoneX branch from f61aaad to 9180ff5 Compare May 11, 2022 18:38
@ken0nek
Copy link
Contributor Author

ken0nek commented May 18, 2022

@sota000 Rebased, and all checks have passed 👍 Could you take a look again?

@cortinico
Copy link
Contributor

and we won't be able to delete the property just yet.

As previously mentioned, this can't land as it is. There are internal usages of that property.
The reason why you see all green is because this PR is older than 30 days so the internal failures are not exported anymore.

@amgleitman
Copy link

amgleitman commented Jul 19, 2022 •
edited
Loading

Any updates from Meta regarding this? As per this discussion post, it would be nice to bring this in and get rid of a call to UIScreen.main.

@cortinico
Copy link
Contributor

There are internal usages of that property.

No updates since my last message

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 13, 2024
@ken0nek
Copy link
Contributor Author

ken0nek commented Apr 14, 2024

ref: #38940

@ken0nek
Copy link
Contributor Author

ken0nek commented Apr 14, 2024

How should we proceed?

  1. Rename isIPhoneX_deprecated to isIPhoneNotched
  2. Remove isIPhoneX_deprecated

@github-actions github-actions bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Apr 15, 2024
@react-native-bot
Copy link
Collaborator

This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@react-native-bot react-native-bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 12, 2024
@ken0nek
Copy link
Contributor Author

ken0nek commented Oct 16, 2024

I will rebase or update this pull request against the latest main.

@react-native-bot react-native-bot removed the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ken0nek @analysis-bot @facebook-github-bot @sota000 @cortinico @amgleitman @react-native-bot