delete unused RCTSurfaceHostingProxyRootView initializers #38868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
Base commit: 676676c |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 8, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Differential Revision: D48140101 fbshipit-source-id: dff2ecf52a0a9623d61d76e31b7fc49bdf6ccbb3
philIip
force-pushed
the
export-D48140101
branch
from
33981a0 to
0c4fb6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 8, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Differential Revision: D48140101 fbshipit-source-id: 8d388dbc394a09ab68f5a977d32081d6dfd0bfd0
philIip
force-pushed
the
export-D48140101
branch
from
0c4fb6d to
ffd9822
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 42794ce2cd31bbc402c6cad8bc95c444e7075b46
philIip
force-pushed
the
export-D48140101
branch
from
ffd9822 to
301733f
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 919190ee5fb98162bbeb8052f032d6c42b1e3f19
philIip
force-pushed
the
export-D48140101
branch
from
301733f to
73d46f8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: efddd5ae5e8053d4fb691f7c01ff55f45da309b8
philIip
force-pushed
the
export-D48140101
branch
from
73d46f8 to
20a5238
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: a4dbdbf28248cf5187f97fb2174b2424d02a15fa
philIip
force-pushed
the
export-D48140101
branch
from
20a5238 to
f4bad55
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 9, 2023
…8868) Summary: Pull Request resolved: facebook#38868 Changelog: [iOS][Breaking] after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 072445b27a36bdd813abb1a8605372320d8271df
philIip
force-pushed
the
export-D48140101
branch
from
f4bad55 to
83b0141
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 10, 2023
Summary: Pull Request resolved: facebook#38869 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: mdvacca, cipolleschi Differential Revision: D48140317 fbshipit-source-id: d87ea48f911de08e260c2c12cc5141565afb084a
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 10, 2023
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: aaaf99f6f94d14d6620f7cfbe5fdb013808a6ff5
philIip
force-pushed
the
export-D48140101
branch
from
83b0141 to
06f4fbf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 4249915e43b0456b343fb25ee80dc04358ab1c81
philIip
force-pushed
the
export-D48140101
branch
from
e467a98 to
f630168
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 114ad85cbe9bfe442c4fcd08260f733297d0965f
philIip
force-pushed
the
export-D48140101
branch
from
f630168 to
5a62400
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#38869 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: mdvacca, cipolleschi Differential Revision: D48140317 fbshipit-source-id: 6c4581e21f789a744214dbaf8ece56883de1cc68
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#38869 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: mdvacca, cipolleschi Differential Revision: D48140317 fbshipit-source-id: dea88cecf93d3ae02c84bfc2144e57752d75cfe7
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 58565af3d58fc3f0673964cf1ac2a0e1bd206de8
philIip
force-pushed
the
export-D48140101
branch
from
5a62400 to
11e8d01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: 93976d05e52911301879ddaae1f1f9a181fc176f
philIip
force-pushed
the
export-D48140101
branch
from
11e8d01 to
378ad80
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 16, 2023
Summary: Pull Request resolved: facebook#38869 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: mdvacca, cipolleschi Differential Revision: D48140317 fbshipit-source-id: 382fc9363e238cf391557a2bc76daada65aed2c9
…stingProxyRootView Differential Revision: D48140102 fbshipit-source-id: c93424e981dd10df17513e0633cf929675c5721c
…8868) Summary: Pull Request resolved: facebook#38868 ## Changelog: [iOS][Breaking] - After [facebook#38864](facebook#38864), these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old. Reviewed By: mdvacca Differential Revision: D48140101 fbshipit-source-id: b99b714c74af2c2ac9ddc50a18891e1eec55db8b
|
This pull request was exported from Phabricator. Differential Revision: D48140101 |
philIip
force-pushed
the
export-D48140101
branch
from
378ad80 to
22ab0e6
Compare
|
This pull request was successfully merged by @philIip in 8b4a353. When will my fix make it into a release? | Upcoming Releases |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 18, 2023
Summary: Pull Request resolved: #38869 ## Changelog: [iOS][Breaking]- After [#38866](#38866) and [#38868](#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: mdvacca, cipolleschi Differential Revision: D48140317 fbshipit-source-id: 930c79b3828e0197c5dd2841875b830fc211e2a6
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 22, 2023
Summary: ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Differential Revision: D48577192 fbshipit-source-id: 94b59ed242b13547f0678c9f5616c33c021f840e
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 22, 2023
Summary: Pull Request resolved: facebook#39118 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Differential Revision: D48577192 fbshipit-source-id: a7b246ec990495ed149a5bd9f71197b675574e44
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39118 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: christophpurrer Differential Revision: D48577192 fbshipit-source-id: 789b96d2872448a49621184906be63164edd4788
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: facebook#39118 ## Changelog: [iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: christophpurrer Differential Revision: D48577192 fbshipit-source-id: 8726dc0cff60542e8429aae1d15a8e793b2f2c1f
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 23, 2023
Summary: Pull Request resolved: #39118 ## Changelog: [iOS][Breaking]- After [#38866](#38866) and [#38868](#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view. Reviewed By: christophpurrer Differential Revision: D48577192 fbshipit-source-id: 8dbc96f1844d0ca1ed603cbe446575571c5f3e3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [iOS][Breaking]
after D48139820, these are not needed anymore. there's some logic with the bridge, but since we're treating new arch as one piece moving forward, i don't really think they're that important. plus that logic is like really old.
Differential Revision: D48140101