New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHostingProxyRootView #38866

Closed

philIip wants to merge 1 commit into facebook:main from philIip:export-D48140102

Contributor

philIip commented Aug 8, 2023

Summary:
Changelog: [Internal]

All callsites to initWithSurface:sizeMeasureMode:moduleRegistry pass down RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact. since that's the case, let's simplify the constructor since initWithSurface: passes that value by default.

Differential Revision: D48140102

facebook-github-bot added CLA Signed p: Facebook Partner fb-exported labels

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

analysis-bot commented Aug 8, 2023 •

edited

Loading

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	8,948,137	+13
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	9,541,969	+13
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: 676676c
Branch: main

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

c8b56c3

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: 9076e3431b590125e30e4973cf4eec4a43c00499

philIip force-pushed the export-D48140102 branch from 1defa37 to c8b56c3 Compare

August 8, 2023 23:12

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

1 similar comment

Contributor

facebook-github-bot commented Aug 8, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

bbbbcfc

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: 62218abe97eb2152865f5581e016af32ad636249

philIip force-pushed the export-D48140102 branch from c8b56c3 to bbbbcfc Compare

August 8, 2023 23:19

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

57a0cbe

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: 93df37e51316183ef51a221973f706d134fe8460

philIip force-pushed the export-D48140102 branch from bbbbcfc to 57a0cbe Compare

August 9, 2023 01:52

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

1 similar comment

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

be7e198

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: 0de00d67b8dd2327de885b973df185704ae9e49d

philIip force-pushed the export-D48140102 branch from 57a0cbe to be7e198 Compare

August 9, 2023 03:44

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

41d07b3

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: ab9e6751d17c6c77aab6422226d5c57aad9adfb2

philIip force-pushed the export-D48140102 branch from be7e198 to 41d07b3 Compare

August 9, 2023 03:57

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

1 similar comment

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

cc6c3e0

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: ac93361423c2fdfce0557482a5e30172b8107b29

philIip force-pushed the export-D48140102 branch from 41d07b3 to cc6c3e0 Compare

August 9, 2023 04:17

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

f1e086b

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

Changelog: [Internal]

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Differential Revision: D48140102

fbshipit-source-id: 6c6fef9503bc54a2b2ca76a374a408f8d45af996

philIip force-pushed the export-D48140102 branch from cc6c3e0 to f1e086b Compare

August 9, 2023 04:22

Contributor

facebook-github-bot commented Aug 9, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused RCTSurfaceHostingView selectors (facebook#38869)

0a76aee

Summary:
Pull Request resolved: facebook#38869

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48140317

fbshipit-source-id: d87ea48f911de08e260c2c12cc5141565afb084a

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

d579a81

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: 976579779f531083a639bda3eb514feba99f4047

philIip force-pushed the export-D48140102 branch from f1e086b to d579a81 Compare

August 10, 2023 00:02

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

4962f21

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: a3f8ae019be5454c7dd04a81b66eeb98fafbea01

philIip force-pushed the export-D48140102 branch from 2a5e56c to 4962f21 Compare

August 16, 2023 16:11

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused RCTSurfaceHostingView selectors (facebook#38869)

0497f52

Summary:
Pull Request resolved: facebook#38869

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48140317

fbshipit-source-id: 6c4581e21f789a744214dbaf8ece56883de1cc68

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

329f782

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: cf5b95ae6e9fe05fbb4e838e7e8b4ed089e0fc56

philIip force-pushed the export-D48140102 branch from 4962f21 to 329f782 Compare

August 16, 2023 16:46

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused RCTSurfaceHostingView selectors (facebook#38869)

5ba8802

Summary:
Pull Request resolved: facebook#38869

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48140317

fbshipit-source-id: dea88cecf93d3ae02c84bfc2144e57752d75cfe7

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

45a108b

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: f68c87685dbc0c7bc03a44cf8c32c4d2ea1d50fe

philIip force-pushed the export-D48140102 branch from 329f782 to 45a108b Compare

August 16, 2023 17:53

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused RCTSurfaceHostingView selectors (facebook#38869)

99a36d6

Summary:
Pull Request resolved: facebook#38869

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48140317

fbshipit-source-id: 382fc9363e238cf391557a2bc76daada65aed2c9

philIip added a commit to philIip/react-native that referenced this pull request


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

5df456f

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: 40c45309354926d6f8b3eb36fc78b8db4cc7cc2a

philIip force-pushed the export-D48140102 branch from 45a108b to 5df456f Compare

August 16, 2023 22:51


          remove RCTSurfaceSizeMeasureMode from public contract of RCTSurfaceHo…

3ca948c

…stingProxyRootView (facebook#38866)

Summary:
Pull Request resolved: facebook#38866

## Changelog:

[iOS][Breaking] - Remove sizeMeasureMode argument from RCTSurfaceHostingProxyRootView constructor

All callsites to `initWithSurface:sizeMeasureMode:moduleRegistry` pass down `RCTSurfaceSizeMeasureModeWidthExact | RCTSurfaceSizeMeasureModeHeightExact`. since that's the case, let's simplify the constructor since `initWithSurface:` passes that value by default.

Reviewed By: sammy-SC, cipolleschi

Differential Revision: D48140102

fbshipit-source-id: 091b53f86e8bc6e2d28419d76161e30eda051cbe

Contributor

facebook-github-bot commented Aug 16, 2023

This pull request was exported from Phabricator. Differential Revision: D48140102

philIip force-pushed the export-D48140102 branch from 5df456f to 3ca948c Compare

August 16, 2023 22:57

github-actions bot commented Aug 17, 2023

This pull request was successfully merged by @philIip in 0d83c1a.

^{When will my fix make it into a release? | Upcoming Releases}

github-actions bot added the Merged label

facebook-github-bot closed this in

0d83c1a

facebook-github-bot pushed a commit that referenced this pull request


          delete unused RCTSurfaceHostingView selectors (#38869)

8548eb5

Summary:
Pull Request resolved: #38869

## Changelog:

[iOS][Breaking]- After [#38866](#38866) and [#38868](#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48140317

fbshipit-source-id: 930c79b3828e0197c5dd2841875b830fc211e2a6

facebook-github-bot added the Reverted label

Contributor

facebook-github-bot commented Aug 18, 2023

This pull request has been reverted by f2b1024.

philIip mentioned this pull request

delete unused selectors from hosting views #39118

Closed

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused selectors from hosting views

b8b1969

Summary:
## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Differential Revision: D48577192

fbshipit-source-id: 94b59ed242b13547f0678c9f5616c33c021f840e

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused selectors from hosting views (facebook#39118)

c726931

Summary:
Pull Request resolved: facebook#39118

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Differential Revision: D48577192

fbshipit-source-id: a7b246ec990495ed149a5bd9f71197b675574e44

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused selectors from hosting views (facebook#39118)

197e87c

Summary:
Pull Request resolved: facebook#39118

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: christophpurrer

Differential Revision: D48577192

fbshipit-source-id: 789b96d2872448a49621184906be63164edd4788

philIip added a commit to philIip/react-native that referenced this pull request


          delete unused selectors from hosting views (facebook#39118)

8ddc6a3

Summary:
Pull Request resolved: facebook#39118

## Changelog:

[iOS][Breaking]- After [facebook#38866](facebook#38866) and [facebook#38868](facebook#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: christophpurrer

Differential Revision: D48577192

fbshipit-source-id: 8726dc0cff60542e8429aae1d15a8e793b2f2c1f

facebook-github-bot pushed a commit that referenced this pull request


          delete unused selectors from hosting views (#39118)

ab6349a

Summary:
Pull Request resolved: #39118

## Changelog:

[iOS][Breaking]- After [#38866](#38866) and [#38868](#38868), these are not needed anymore. instead of depending on the host view and overriding `createSurfaceWithBridge:` in a subclass create a specialized surface, we just rely on composition instead and provide a surface to the hosting view.

Reviewed By: christophpurrer

Differential Revision: D48577192

fbshipit-source-id: 8dbc96f1844d0ca1ed603cbe446575571c5f3e3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported Merged p: Facebook Partner Reverted