Remove references to ShadowNodeFamilyFragment when not used to create new instances of ShadowNodeFamily #37772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46190382 |
Base commit: 108309e |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jun 8, 2023
… new instances of ShadowNodeFamily (facebook#37772) Summary: Pull Request resolved: facebook#37772 Changelog: [internal] `ShadowNodeFragment` is used in multiple places as a general definition for the fragment, but it lacks information that's going to be constructed in the fragment itself in the future (like `eventEmitter` in D46149084). This migrates some of the usages of this fragment to the `ShadowNodeFamily` directly (as they already have access to it). Reviewed By: javache, sammy-SC Differential Revision: D46190382 fbshipit-source-id: 4ee1499f24df62674973435245c59a559357610e
rubennorte
force-pushed
the
export-D46190382
branch
from
2ac2f14 to
c3c1122
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46190382 |
…w node wrappers Differential Revision: D46190383 fbshipit-source-id: 3d56622ffd79656cc3d5c3257c076ab3743bb726
… new instances of ShadowNodeFamily (facebook#37772) Summary: Pull Request resolved: facebook#37772 Changelog: [internal] `ShadowNodeFragment` is used in multiple places as a general definition for the fragment, but it lacks information that's going to be constructed in the fragment itself in the future (like `eventEmitter` in D46149084). This migrates some of the usages of this fragment to the `ShadowNodeFamily` directly (as they already have access to it). Reviewed By: javache, sammy-SC Differential Revision: D46190382 fbshipit-source-id: 01804abb88c0566975630f85ec50db2d10b89e4a
rubennorte
force-pushed
the
export-D46190382
branch
from
c3c1122 to
ce153e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46190382 |
Contributor
|
This pull request has been merged in a88c0ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
ShadowNodeFragmentis used in multiple places as a general definition for the fragment, but it lacks information that's going to be constructed in the fragment itself in the future (likeeventEmitterin D46149084).This migrates some of the usages of this fragment to a new class that works as an interface to access information from shadow node family.
Reviewed By: sammy-SC
Differential Revision: D46190382