Remove references to ShadowNodeFamilyFragment when not used to create new instances of ShadowNodeFamily

Summary:
Changelog: [internal]

`ShadowNodeFragment` is used in multiple places as a general definition for the fragment, but it lacks information that's going to be constructed in the fragment itself in the future (like `eventEmitter` in D46149084).

This migrates some of the usages of this fragment to a new class that works as an interface to access information from shadow node family.

Reviewed By: sammy-SC

Differential Revision: D46190382

fbshipit-source-id: 1fef0992ad15191fa7819d4356db447f158f0b63

Author: rubennorte

packages/react-native/ReactCommon/react/renderer/components/image/ImageShadowNode.h

@@ -11,6 +11,7 @@
 #include <react/renderer/components/image/ImageProps.h>
 #include <react/renderer/components/image/ImageState.h>
 #include <react/renderer/components/view/ConcreteViewShadowNode.h>
+#include <react/renderer/core/ShadowNodeFamilyInfo.h>
 #include <react/renderer/imagemanager/ImageManager.h>
 #include <react/renderer/imagemanager/primitives.h>
 
@@ -42,7 +43,7 @@ class ImageShadowNode final : public ConcreteViewShadowNode<
 
   static ImageState initialStateData(
       Props::Shared const &props,
-      ShadowNodeFamilyFragment const &familyFragment,
+      ShadowNodeFamilyInfo const & /*family*/,
       ComponentDescriptor const &componentDescriptor) {
     auto imageSource = ImageSource{ImageSource::Type::Invalid};
     return {imageSource, {imageSource, nullptr}, 0};

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewShadowNode.cpp

@@ -50,7 +50,7 @@ void ScrollViewShadowNode::updateScrollContentOffsetIfNeeded() {
 
 ScrollViewState ScrollViewShadowNode::initialStateData(
     Props::Shared const &props,
-    const ShadowNodeFamilyFragment & /*familyFragment*/,
+    const ShadowNodeFamilyInfo & /*family*/,
     const ComponentDescriptor & /*componentDescriptor*/) {
   return {static_cast<ScrollViewProps const &>(*props).contentOffset, {}, 0};
 }

packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollViewShadowNode.h

@@ -12,6 +12,7 @@
 #include <react/renderer/components/scrollview/ScrollViewState.h>
 #include <react/renderer/components/view/ConcreteViewShadowNode.h>
 #include <react/renderer/core/LayoutContext.h>
+#include <react/renderer/core/ShadowNodeFamilyInfo.h>
 
 namespace facebook::react {
 
@@ -30,7 +31,7 @@ class ScrollViewShadowNode final : public ConcreteViewShadowNode<
 
   static ScrollViewState initialStateData(
       Props::Shared const &props,
-      ShadowNodeFamilyFragment const &familyFragment,
+      ShadowNodeFamilyInfo const &family,
       ComponentDescriptor const &componentDescriptor);
 
 #pragma mark - LayoutableShadowNode

packages/react-native/ReactCommon/react/renderer/core/ConcreteComponentDescriptor.h

@@ -18,6 +18,7 @@
 #include <react/renderer/core/Props.h>
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/core/ShadowNode.h>
+#include <react/renderer/core/ShadowNodeFamilyInfo.h>
 #include <react/renderer/core/ShadowNodeFragment.h>
 #include <react/renderer/core/State.h>
 #include <react/renderer/graphics/Float.h>
@@ -161,7 +162,7 @@ class ConcreteComponentDescriptor : public ComponentDescriptor {
     return std::make_shared<ConcreteState>(
         std::make_shared<ConcreteStateData const>(
             ConcreteShadowNode::initialStateData(
-                props, ShadowNodeFamilyFragment::build(*family), *this)),
+                props, ShadowNodeFamilyInfo::build(*family), *this)),
         family);
   }
 

packages/react-native/ReactCommon/react/renderer/core/ConcreteShadowNode.h

@@ -13,6 +13,7 @@
 #include <react/renderer/core/PropsParserContext.h>
 #include <react/renderer/core/RawProps.h>
 #include <react/renderer/core/ShadowNode.h>
+#include <react/renderer/core/ShadowNodeFamilyInfo.h>
 #include <react/renderer/core/StateData.h>
 
 namespace facebook::react {
@@ -87,8 +88,8 @@ class ConcreteShadowNode : public BaseShadowNodeT {
 
   static ConcreteStateData initialStateData(
       Props::Shared const & /*props*/,
-      ShadowNodeFamilyFragment const &familyFragment,
-      ComponentDescriptor const &componentDescriptor) {
+      ShadowNodeFamilyInfo const & /*family*/,
+      ComponentDescriptor const & /*componentDescriptor*/) {
     return {};
   }
 

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamily.h

@@ -15,6 +15,7 @@
 #include <react/renderer/core/EventEmitter.h>
 #include <react/renderer/core/ReactPrimitives.h>
 #include <react/renderer/core/ShadowNodeFamilyFragment.h>
+#include <react/renderer/core/ShadowNodeFamilyInfo.h>
 
 namespace facebook::react {
 
@@ -97,6 +98,7 @@ class ShadowNodeFamily final {
  private:
   friend ShadowNode;
   friend ShadowNodeFamilyFragment;
+  friend ShadowNodeFamilyInfo;
   friend State;
 
   /*

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamilyFragment.h

@@ -15,6 +15,13 @@ namespace facebook::react {
 class ShadowNodeFamily;
 
 /*
+ * This is a collection of fields serving as a specification to create new
+ * `ShadowNodeFamily` instances.
+ *
+ * Do not use this class as a general purpose container to share information
+ * about a `ShadowNodeFamily`. Pelase define specific purpose containers in
+ * those cases.
+ *
  * Note: All of the fields are `const &` references (essentially just raw
  * pointers) which means that the Fragment does not copy/store them nor
  * retain ownership of them.

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamilyInfo.cpp

@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#include "ShadowNodeFamilyInfo.h"
+
+#include <react/renderer/core/ShadowNodeFamily.h>
+
+namespace facebook::react {
+
+ShadowNodeFamilyInfo ShadowNodeFamilyInfo::build(
+    ShadowNodeFamily const &family) {
+  return {
+      family.tag_,
+      family.surfaceId_,
+      family.eventEmitter_,
+  };
+}
+
+} // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeFamilyInfo.h

@@ -0,0 +1,30 @@
+/*
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+#pragma once
+
+#include <react/renderer/core/EventEmitter.h>
+#include <react/renderer/core/ReactPrimitives.h>
+
+namespace facebook::react {
+
+class ShadowNodeFamily;
+
+/*
+ * This is a public interface to interact with `ShadowNodeFamily`, without
+ * providing access to the original family
+ */
+class ShadowNodeFamilyInfo final {
+ public:
+  static ShadowNodeFamilyInfo build(ShadowNodeFamily const &family);
+
+  Tag const tag;
+  SurfaceId const surfaceId;
+  EventEmitter::Shared const eventEmitter;
+};
+
+} // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/element/ComponentBuilder.h

@@ -12,7 +12,6 @@
 #include <react/renderer/componentregistry/ComponentDescriptorRegistry.h>
 #include <react/renderer/core/ComponentDescriptor.h>
 #include <react/renderer/core/ShadowNode.h>
-#include <react/renderer/core/ShadowNodeFamilyFragment.h>
 #include <react/renderer/core/ShadowNodeFragment.h>
 
 #include <react/renderer/element/Element.h>