Skip to content

Add debugging docs link to NewAppScreen #37552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add debugging docs link to NewAppScreen #37552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-native/Libraries/NewAppScreen/components/DebugInstructions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,15 @@ const DebugInstructions: () => Node = Platform.select({
ios: () => (
<Text>
Press <Text style={styles.highlight}>Cmd + D</Text> in the simulator or{' '}
<Text style={styles.highlight}>Shake</Text> your device to open the React
Native debug menu.
<Text style={styles.highlight}>Shake</Text> your device to open the Dev
Menu.
</Text>
),
default: () => (
<Text>
Press <Text style={styles.highlight}>Cmd or Ctrl + M</Text> or{' '}
<Text style={styles.highlight}>Shake</Text> your device to open the React
Native debug menu.
<Text style={styles.highlight}>Shake</Text> your device to open the Dev
Menu.
</Text>
),
});
Expand Down
11 changes: 9 additions & 2 deletions packages/react-native/Libraries/NewAppScreen/components/LearnMoreLinks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,20 @@ const links = [
},
{
id: 7,
title: 'Debugging',
link: 'https://facebook.github.io/react-native/docs/debugging',
description:
'Learn about the tools available to debug and inspect your app.',
},
{
id: 8,
title: 'Help',
link: 'https://reactnative.dev/help',
link: 'https://facebook.github.io/react-native/help',
Copy link
Contributor

@Pranav-yadav Pranav-yadav May 24, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link redirects to: https://reactnative.dev/community/overview
And the older one too.
Why not just use the "actual" link or keep the shorter one?

P.S.: I may be unaware of the context here...

Copy link
Contributor

@Pranav-yadav Pranav-yadav May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NickGerleman IIRC the fb gh pages deployment was discontinued?
Why not just use official website links?

description:
'Need more help? There are many other React Native developers who may have the answer.',
},
{
id: 8,
id: 9,
title: 'Follow us on Twitter',
link: 'https://twitter.com/reactnative',
description:
Expand Down