Add debugging docs link to NewAppScreen #37552
Closed
+13
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46149252 |
| id: 8, | ||
| title: 'Help', | ||
| link: 'https://reactnative.dev/help', | ||
| link: 'https://facebook.github.io/react-native/help', |
Contributor
There was a problem hiding this comment.
This link redirects to: https://reactnative.dev/community/overview
And the older one too.
Why not just use the "actual" link or keep the shorter one?
P.S.: I may be unaware of the context here...
Contributor
There was a problem hiding this comment.
@NickGerleman IIRC the fb gh pages deployment was discontinued?
Why not just use official website links?
Base commit: bf1bd48 |
Summary: Pull Request resolved: facebook#37552 - Add debugging docs link to `NewAppScreen`. - Align "React Native debug menu" term in `DebugInstructions` to "Dev Menu". Changelog: [General][Changed] Add debugging docs link to new app screen Reviewed By: cortinico Differential Revision: D46149252 fbshipit-source-id: 8a6f3263227f8a7393467fa2c63c0350ea9403a9
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46149252 |
Contributor
|
This pull request has been merged in be8af22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
NewAppScreen.DebugInstructionsto "Dev Menu".Changelog:
[General][Changed] Add debugging docs link to new app screen
Differential Revision: D46149252