Call setSurfaceProps when props change in SurfaceHandler #37087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45272046 |
) Summary: Pull Request resolved: facebook#37087 changelog: [internal] Surface props can change during life cycle of a surface. This was supported before the new renderer as well. AppRegistry has a corresponding method for this: `AppRegistry.setSurfaceProps`. To add support for this, we just need to call into `UIManager::setSurfaceProps`. Reviewed By: rshest Differential Revision: D45272046 fbshipit-source-id: 0c000bf12ff225d9989a34d91ea39de95878b5d1
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D45272046 |
sammy-SC
force-pushed
the
export-D45272046
branch
from
cb654a4 to
c3fa976
Compare
Base commit: 41c6f0f |
Contributor
|
This pull request has been merged in 09a810a. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
) Summary: Pull Request resolved: facebook#37087 changelog: [internal] Surface props can change during life cycle of a surface. This was supported before the new renderer as well. AppRegistry has a corresponding method for this: `AppRegistry.setSurfaceProps`. To add support for this, we just need to call into `UIManager::setSurfaceProps`. Reviewed By: rshest Differential Revision: D45272046 fbshipit-source-id: d138b57d5c83f554839b0db0e6721045b8dc81ef
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: Pull Request resolved: facebook#37087 changelog: [internal] Surface props can change during life cycle of a surface. This was supported before the new renderer as well. AppRegistry has a corresponding method for this: `AppRegistry.setSurfaceProps`. To add support for this, we just need to call into `UIManager::setSurfaceProps`. Reviewed By: rshest Differential Revision: D45272046 fbshipit-source-id: d138b57d5c83f554839b0db0e6721045b8dc81ef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
changelog: [internal]
Surface props can change during life cycle of a surface. This was supported before the new renderer as well. AppRegistry has a corresponding method for this:
AppRegistry.setSurfaceProps.To add support for this, we just need to call into
UIManager::setSurfaceProps.Reviewed By: rshest
Differential Revision: D45272046