Fix: Adapt template to new rules #36705
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in 3ac7a5e. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Recently, we changed the logic to verify the body of a PR so that it is more compatible internally and externally, in both ways. But we forgot to update the template, so right now, all the created PR are incompatible with the internal PR checker. The required change is to have `:` after the Changelog title. For consistency, I added the `:` after ALL the titles. ## Changelog: [Internal] - Changed the PR template to align it to the new rules Pull Request resolved: facebook#36705 Test Plan: No danger errors nor internal linter errors Reviewed By: christophpurrer Differential Revision: D44503519 Pulled By: cipolleschi fbshipit-source-id: 43963c3cf774d19d6de8e86b18b684e76dd0fe87
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Recently, we changed the logic to verify the body of a PR so that it is more compatible internally and externally, in both ways. But we forgot to update the template, so right now, all the created PR are incompatible with the internal PR checker. The required change is to have `:` after the Changelog title. For consistency, I added the `:` after ALL the titles. [Internal] - Changed the PR template to align it to the new rules Pull Request resolved: facebook#36705 Test Plan: No danger errors nor internal linter errors Reviewed By: christophpurrer Differential Revision: D44503519 Pulled By: cipolleschi fbshipit-source-id: 43963c3cf774d19d6de8e86b18b684e76dd0fe87
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Recently, we changed the logic to verify the body of a PR so that it is more compatible internally and externally, in both ways. But we forgot to update the template, so right
now, all the created PR are incompatible with the internal PR checker.
The required change is to have
:after the Changelog title.For consistency, I added the
:after ALL the titles.Changelog:
[Internal] - Changed the PR template to align it to the new rules
Test Plan
No danger errors nor internal linter errors