You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Summary:
Recently, we changed the logic to verify the body of a PR so that it is more compatible internally and externally, in both ways. But we forgot to update the template, so right
now, all the created PR are incompatible with the internal PR checker.
The required change is to have `:` after the Changelog title.
For consistency, I added the `:` after ALL the titles.
## Changelog:
[Internal] - Changed the PR template to align it to the new rules
Pull Request resolved: facebook#36705
Test Plan: No danger errors nor internal linter errors
Reviewed By: christophpurrer
Differential Revision: D44503519
Pulled By: cipolleschi
fbshipit-source-id: 43963c3cf774d19d6de8e86b18b684e76dd0fe87
Copy file name to clipboardExpand all lines: .github/PULL_REQUEST_TEMPLATE.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,10 +1,10 @@
1
1
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->
2
2
3
-
## Summary
3
+
## Summary:
4
4
5
5
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
6
6
7
-
## Changelog
7
+
## Changelog:
8
8
9
9
<!-- Help reviewers and the release process by writing your own changelog entry.
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->
0 commit comments