Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump RNGP to 0.72.1 #35389

Closed
wants to merge 2 commits into from
Closed

Bump RNGP to 0.72.1 #35389

wants to merge 2 commits into from

Commits on Nov 18, 2022

  1. Void the Maven coordinates for react-native and hermes-engine 

    Summary:
This diff moves the publishing coordinates from:
```
com.facebook.react:react-native
com.facebook.react:hermes-engine
```

to

```
com.facebook.react:react-android
com.facebook.react:hermes-android
```

I've picked those they are the most layout friendly when building from source, but we can discuss if we want others.
I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes.

It should now be possible to still use `implementation("com.facebook.react:react-native:+")` inside libraries
on 0.71+ and RNGP will resolve dependencies correctly.

Changelog:
[Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine

Differential Revision: D41380525

fbshipit-source-id: 5b08f2f88ad8160b2a034b208476b1fbb68069dc
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ce04cb6 View commit details
    Browse the repository at this point in the history

  2. Bump RNGP to 0.72.1 

    Summary:
As the title says, just bumping RNGP

Changelog:
[Internal] [Changed] - Bump RNGP to 0.72.1

Differential Revision: D41398920

fbshipit-source-id: 971c1b03211aef40af9f56d6b9889b23b5d04eb2
    @cortinico @facebook-github-bot
    cortinico authored and facebook-github-bot committed Nov 18, 2022
    Configuration menu
    Copy the full SHA
    736ef5c View commit details
    Browse the repository at this point in the history