Bump RNGP to 0.72.1 #35389
Closed
Bump RNGP to 0.72.1 #35389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary:
This diff moves the publishing coordinates from:
```
com.facebook.react:react-native
com.facebook.react:hermes-engine
```
to
```
com.facebook.react:react-android
com.facebook.react:hermes-android
```
I've picked those they are the most layout friendly when building from source, but we can discuss if we want others.
I've updated the Gradle plugin to have a dependencySubstitution rule + update the template with those changes.
It should now be possible to still use `implementation("com.facebook.react:react-native:+")` inside libraries
on 0.71+ and RNGP will resolve dependencies correctly.
Changelog:
[Android] [Changed] - Void the Maven coordinates for react-native and hermes-engine
Differential Revision: D41380525
fbshipit-source-id: 5b08f2f88ad8160b2a034b208476b1fbb68069dc
Summary: As the title says, just bumping RNGP Changelog: [Internal] [Changed] - Bump RNGP to 0.72.1 Differential Revision: D41398920 fbshipit-source-id: 971c1b03211aef40af9f56d6b9889b23b5d04eb2
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D41398920 |
Base commit: 4d7ddd4 |
Base commit: 4d7ddd4 |
|
PR build artifact for 736ef5c is ready. |
|
PR build artifact for 736ef5c is ready. |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35389 As the title says, just bumping RNGP Changelog: [Internal] [Changed] - Bump RNGP to 0.72.1 Reviewed By: cipolleschi Differential Revision: D41398920 fbshipit-source-id: 39baadc54c604ababe7f558cc1c1291c08aae983
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As the title says, just bumping RNGP
Changelog:
[Internal] [Changed] - Bump RNGP to 0.72.1
Differential Revision: D41398920