Fix ReactAndroid not found in rn-tester build #35058
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
/rebase |
cortinico
approved these changes
Oct 24, 2022
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
github-actions
bot
force-pushed
the
fix-broken-rn-tester-build
branch
from
61fa121
to
30d9fe1
Compare
Base commit: 421bf98 |
|
PR build artifact for 30d9fe1 is ready. |
|
PR build artifact for 30d9fe1 is ready. |
|
This pull request was successfully merged by @robertying in f8cd9f1. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: I tried to build the source locally to test changes with `rn-tester`. However, the gradle build failed due to "./ReactAndroid/gradle.properties (No such file or directory)". I believe this error was introduced by facebook@3d05bac. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Fixed] - Fix ReactAndroid not found in rn-tester build Pull Request resolved: facebook#35058 Test Plan: - Clone the react-native repo. - Run `cd packages/rn-tester`. - Run `yarn install-android-jsc` and encounter the error. - Apply the fix. - Run `yarn install-android-jsc` and build succeeds. Reviewed By: cipolleschi Differential Revision: D40639856 Pulled By: cortinico fbshipit-source-id: 58b51bcad0af7a21cac032c98484c5942a203e4c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I tried to build the source locally to test changes with
rn-tester. However, the gradle build failed due to "./ReactAndroid/gradle.properties (No such file or directory)". I believe this error was introduced by 3d05bac.Changelog
[Internal] [Fixed] - Fix ReactAndroid not found in rn-tester build
Test Plan
cd packages/rn-tester.yarn install-android-jscand encounter the error.yarn install-android-jscand build succeeds.