Skip to content

Commit

Permalink
Fix ReactAndroid not found in rn-tester build (#35058)
Browse files Browse the repository at this point in the history
Summary:
I tried to build the source locally to test changes with `rn-tester`. However, the gradle build failed due to "./ReactAndroid/gradle.properties (No such file or directory)". I believe this error was introduced by 3d05bac.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Fixed] - Fix ReactAndroid not found in rn-tester build

Pull Request resolved: #35058

Test Plan:
- Clone the react-native repo.
- Run `cd packages/rn-tester`.
- Run `yarn install-android-jsc` and encounter the error.
- Apply the fix.
- Run `yarn install-android-jsc` and build succeeds.

Reviewed By: cipolleschi

Differential Revision: D40639856

Pulled By: cortinico

fbshipit-source-id: 58b51bcad0af7a21cac032c98484c5942a203e4c
  • Loading branch information
robertying authored and facebook-github-bot committed Oct 24, 2022
1 parent 421bf98 commit f8cd9f1
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ plugins { id("io.github.gradle-nexus.publish-plugin") version "1.1.0" }

val reactAndroidProperties = java.util.Properties()

File("./ReactAndroid/gradle.properties").inputStream().use { reactAndroidProperties.load(it) }
File("$rootDir/ReactAndroid/gradle.properties").inputStream().use {
reactAndroidProperties.load(it)
}

version =
if (project.hasProperty("isNightly") &&
Expand Down

0 comments on commit f8cd9f1

Please sign in to comment.