Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.circleci): support both architectures in rntester app #34864

Closed

Conversation

hoxyq
Copy link
Contributor

@hoxyq hoxyq commented Oct 4, 2022

Summary

Added a new job to testing RNTester app on both architectures

Changelog

[Internal] [Added] - Support both architectures to test RNTester iOS app

Test Plan

CircleCI jobs

@hoxyq hoxyq requested a review from hramos as a code owner October 4, 2022 14:21
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 4, 2022
@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Oct 4, 2022
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job! Let's see whether CircleCI is happy and green before importing!

.circleci/config.yml Show resolved Hide resolved
@hoxyq hoxyq force-pushed the support-both-architectures-in-rntester branch from c1267f9 to e38fd45 Compare October 4, 2022 14:37
@hoxyq hoxyq force-pushed the support-both-architectures-in-rntester branch from e38fd45 to e4894f6 Compare October 4, 2022 14:38
@facebook-github-bot
Copy link
Contributor

@hoxyq has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,739,362 +0
android hermes armeabi-v7a 7,142,028 +0
android hermes x86 8,050,472 +0
android hermes x86_64 8,022,301 +0
android jsc arm64-v8a 9,607,549 +0
android jsc armeabi-v7a 8,373,071 +0
android jsc x86 9,555,218 +0
android jsc x86_64 10,147,821 +0

Base commit: 97f5ef0
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 97f5ef0
Branch: main

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by Ruslan Lesiutin in 47d2337.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 4, 2022
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…#34864)

Summary:
Added a new job to testing RNTester app on both architectures

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Added] - Support both architectures to test RNTester iOS app

Pull Request resolved: facebook#34864

Test Plan: CircleCI jobs

Reviewed By: cortinico, cipolleschi

Differential Revision: D40062371

fbshipit-source-id: 1a28890edc57b64232d647d85694b34d50a9cd64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. p: Facebook Partner: Facebook Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants