Skip to content

Commit

Permalink
feat(.circleci): support both architectures in rntester app (#34864)
Browse files Browse the repository at this point in the history
Summary:
Added a new job to testing RNTester app on both architectures

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Added] - Support both architectures to test RNTester iOS app

Pull Request resolved: #34864

Test Plan: CircleCI jobs

Reviewed By: cortinico, cipolleschi

Differential Revision: D40062371

fbshipit-source-id: 1a28890edc57b64232d647d85694b34d50a9cd64
  • Loading branch information
Ruslan Lesiutin authored and facebook-github-bot committed Oct 4, 2022
1 parent 8486b4c commit 47d2337
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,10 @@ jobs:
# -------------------------
test_ios_rntester:
executor: reactnativeios
parameters:
architecture:
type: string
default: "OldArch"
steps:
- checkout_code_with_cache
- run_yarn
Expand Down Expand Up @@ -854,9 +858,14 @@ jobs:
set_tarball_path: True
steps:
- run:
name: Install CocoaPods dependencies
name: Install CocoaPods dependencies - Architecture << parameters.architecture >>
command: |
rm -rf packages/rn-tester/Pods
if [[ << parameters.architecture >> == "NewArch" ]]; then
export RCT_NEW_ARCH_ENABLED=1
fi
cd packages/rn-tester && bundle exec pod install
- run:
Expand Down Expand Up @@ -1466,6 +1475,9 @@ workflows:
- test_ios_rntester:
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
- test_ios:
run_unit_tests: true
requires:
Expand Down

0 comments on commit 47d2337

Please sign in to comment.