Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further simplify the New App Template by don't requiring the dynamic library name #34671

Closed
wants to merge 1 commit into from

Commits on Sep 13, 2022

  1. Further simplify the New App Template by don't requiring the dynamic …

    …library name
    
    Summary:
    I'm simplifying the template further by:
    - Do not expose a configurable dynamic library name. Let's use `appmodules`
    and still allow the users to configure it, if needed.
    - Move all the initialization logic inside the `JNI_OnLoad` method
    - Cleanup the `DefaultReactNativeHost` to don't require a dynamic library
    name but just a boolean.
    
    Changelog:
    [Android] [Changed] - Further simplify the New App Template by don't requiring the dynamic library name
    
    Differential Revision: D39462948
    
    fbshipit-source-id: 885eae134d5490064498eb51e7476a6c2cb60231
    cortinico authored and facebook-github-bot committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    469275c View commit details
    Browse the repository at this point in the history