Further simplify the New App Template by don't requiring the dynamic library name #34671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…library name Summary: I'm simplifying the template further by: - Do not expose a configurable dynamic library name. Let's use `appmodules` and still allow the users to configure it, if needed. - Move all the initialization logic inside the `JNI_OnLoad` method - Cleanup the `DefaultReactNativeHost` to don't require a dynamic library name but just a boolean. Changelog: [Android] [Changed] - Further simplify the New App Template by don't requiring the dynamic library name Differential Revision: D39462948 fbshipit-source-id: 885eae134d5490064498eb51e7476a6c2cb60231
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39462948 |
|
This pull request was successfully merged by @cortinico in 59ae048. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…library name (facebook#34671) Summary: Pull Request resolved: facebook#34671 I'm simplifying the template further by: - Do not expose a configurable dynamic library name. Let's use `appmodules` and still allow the users to configure it, if needed. - Move all the initialization logic inside the `JNI_OnLoad` method - Cleanup the `DefaultReactNativeHost` to don't require a dynamic library name but just a boolean. Changelog: [Android] [Changed] - Further simplify the New App Template by don't requiring the dynamic library name Reviewed By: cipolleschi Differential Revision: D39462948 fbshipit-source-id: 737733fc263162a0baf3b7a451e48b8616679d3b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm simplifying the template further by:
appmodulesand still allow the users to configure it, if needed.
JNI_OnLoadmethodDefaultReactNativeHostto don't require a dynamic libraryname but just a boolean.
Changelog:
[Android] [Changed] - Further simplify the New App Template by don't requiring the dynamic library name
Differential Revision: D39462948